[Scst-svn] SF.net SVN: scst: [398] trunk

[<vl...@us...>]

Revision: 398
          http://scst.svn.sourceforge.net/scst/?rev=398&view=rev
Author:   vlnb
Date:     2008-05-27 07:26:15 -0700 (Tue, 27 May 2008)

Log Message:
-----------
Patch from Bart Van Assche <bar...@gm...>:

The patch below fixes the following categories of checkpatch complaints:
- ERROR: switch and case should be at the same indent
- ERROR: do not initialise statics to 0 or NULL
- ERROR: use tabs not spaces

I have verified that the SCST source code still compiles.

Signed-off-by: Bart Van Assche <bar...@gm...>

Modified Paths:
--------------
    trunk/iscsi-scst/kernel/config.c
    trunk/iscsi-scst/kernel/event.c
    trunk/scst/src/dev_handlers/scst_vdisk.c
    trunk/scst/src/scst_lib.c
    trunk/scst/src/scst_main.c
    trunk/scst/src/scst_targ.c
    trunk/srpt/src/ib_srpt.c

Modified: trunk/iscsi-scst/kernel/config.c
===================================================================
--- trunk/iscsi-scst/kernel/config.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/iscsi-scst/kernel/config.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -526,7 +526,7 @@
 static void iscsi_dump_char(int ch)
 {
 	static unsigned char text[16];
-	static int i = 0;
+	static int i;
 
 	if (ch < 0) {
 		while ((i % 16) != 0) {

Modified: trunk/iscsi-scst/kernel/event.c
===================================================================
--- trunk/iscsi-scst/kernel/event.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/iscsi-scst/kernel/event.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -89,7 +89,7 @@
 {
 	struct sk_buff *skb;
 	struct nlmsghdr *nlh;
-	static u32 seq = 0;
+	static u32 seq;
 
 	if (!(skb = alloc_skb(NLMSG_SPACE(len), gfp_mask)))
 		return -ENOMEM;

Modified: trunk/scst/src/dev_handlers/scst_vdisk.c
===================================================================
--- trunk/scst/src/dev_handlers/scst_vdisk.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/scst/src/dev_handlers/scst_vdisk.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -648,11 +648,11 @@
 static inline int vdisk_sync_queue_type(enum scst_cmd_queue_type qt)
 {
 	switch (qt) {
-		case SCST_CMD_QUEUE_ORDERED:
-		case SCST_CMD_QUEUE_HEAD_OF_QUEUE:
-			return 1;
-		default:
-			return 0;
+	case SCST_CMD_QUEUE_ORDERED:
+	case SCST_CMD_QUEUE_HEAD_OF_QUEUE:
+		return 1;
+	default:
+		return 0;
 	}
 }
 

Modified: trunk/scst/src/scst_lib.c
===================================================================
--- trunk/scst/src/scst_lib.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/scst/src/scst_lib.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -2443,8 +2443,8 @@
 		list_for_each_entry(tgt_dev, &dev->dev_tgt_dev_list,
 				    dev_tgt_dev_list_entry) {
 			TRACE(TRACE_MGMT, "Clearing RESERVE'ation for tgt_dev "
-			        "lun %Ld",
-			        (long long unsigned int)tgt_dev->lun);
+				"lun %Ld",
+				(long long unsigned int)tgt_dev->lun);
 			clear_bit(SCST_TGT_DEV_RESERVED,
 				  &tgt_dev->tgt_dev_flags);
 		}

Modified: trunk/scst/src/scst_main.c
===================================================================
--- trunk/scst/src/scst_main.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/scst/src/scst_main.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -1217,7 +1217,7 @@
 int __scst_add_cmd_threads(int num)
 {
 	int res = 0, i;
-	static int scst_thread_num = 0;
+	static int scst_thread_num;
 
 	TRACE_ENTRY();
 

Modified: trunk/scst/src/scst_targ.c
===================================================================
--- trunk/scst/src/scst_targ.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/scst/src/scst_targ.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -3494,15 +3494,15 @@
 {
 	switch (mgmt_fn) {
 #ifdef ABORT_CONSIDER_FINISHED_TASKS_AS_NOT_EXISTING
-		case SCST_ABORT_TASK:
+	case SCST_ABORT_TASK:
 #endif
 #if 0
-		case SCST_ABORT_TASK_SET:
-		case SCST_CLEAR_TASK_SET:
+	case SCST_ABORT_TASK_SET:
+	case SCST_CLEAR_TASK_SET:
 #endif
-			return 1;
-		default:
-			return 0;
+		return 1;
+	default:
+		return 0;
 	}
 }
 

Modified: trunk/srpt/src/ib_srpt.c
===================================================================
--- trunk/srpt/src/ib_srpt.c	2008-05-26 11:13:04 UTC (rev 397)
+++ trunk/srpt/src/ib_srpt.c	2008-05-27 14:26:15 UTC (rev 398)
@@ -60,7 +60,7 @@
 	struct task_struct *thread;
 };
 
-static u64 mellanox_ioc_guid = 0;
+static u64 mellanox_ioc_guid;
 static struct list_head srpt_devices;
 static int thread = 1;
 static struct srpt_thread srpt_thread;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.