[Scim-user] [ scim-Patches-3407286 ] gtk3 support patch

[SourceForge.net <no...@so...>]

Patches item #3407286, was opened at 2011-09-10 11:28
Message generated for change (Comment added) made by stroethoff
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=650541&aid=3407286&group_id=108454

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: tzhuan (tzhuan)
Assigned to: Ronald Stroethoff (stroethoff)
Summary: gtk3 support patch

Initial Comment:
I made a patch for gtk3 support, please consider accepting it, thanks.

----------------------------------------------------------------------

>Comment By: Ronald Stroethoff (stroethoff)
Date: 2011-12-02 05:32

Message:
Today I have downloaded the latest release of SCIM, give it the command
"./bootstrap" and then "./configure"
It worked as expected.
Then I did the same to the download out of latest SVN and did the same,
configure crashed.
It has something to do with the line :
# Check intltool
IT_PROG_INTLTOOL([0.33], [no-xml])
at line 135 in configure.ac
This line is there already 1/2year there, so nothing new.

----------------------------------------------------------------------

Comment By: Rolf (leggewie)
Date: 2011-12-01 10:48

Message:
kroodywar3 already applied the patch in svn a few days ago.  I don't him
him or his skills.  I just want to make sure somebody with the appropriate
skills and level of trust has thoroughly reviewed this before we release
this.

Thanks to everyone involved.

----------------------------------------------------------------------

Comment By: Rolf (leggewie)
Date: 2011-12-01 10:35

Message:
Thanks, Ronald.  To my untrained eye that error doesn't look as if it was
introduced by the patch.  Are you sure the compilation succeeds without
that patch? Are you sure you have all the necessary build dependencies
installed on your host?

----------------------------------------------------------------------

Comment By: Ronald Stroethoff (stroethoff)
Date: 2011-12-01 10:11

Message:
I have tried to compile the new program.
The intention was to look for compile-warnings.
./configure is crashing with the report:
<snip>
checking for
/usr/share/xml/docbook/stylesheet/nwalsh/current/html/docbook.xsl... no
./configure: line 22747: syntax error near unexpected token `0.33,no-xml'
./configure: line 22747: `IT_PROG_INTLTOOL(0.33,no-xml)'
<snip>
Can anybody help me with what is going wrong?

----------------------------------------------------------------------

Comment By: Forrest Kong (kroodywar3)
Date: 2011-10-13 00:50

Message:
I will check for that, thanks for your patch

----------------------------------------------------------------------

Comment By: Rolf (leggewie)
Date: 2011-09-11 23:18

Message:
targeting resolution for next release

----------------------------------------------------------------------

Comment By: Rolf (leggewie)
Date: 2011-09-11 23:10

Message:
I consider this a very important patch going forward.  Debian is dropping
gtk2 AFAIK and scim would likely be dropped from the next release because
of it.  I'm not a coder, so please review carefully, though!

----------------------------------------------------------------------

Comment By: tzhuan (tzhuan)
Date: 2011-09-11 21:14

Message:
The patch is applied to scim. The scim will generate gtk2's immodule
(extras/clieint/gtk2_im_module) but it is not compatible to gtk3. My patch
creates extras/client/gtk3_im_module so that scim will generate both gtk2
and gtk3's immodules.

----------------------------------------------------------------------

Comment By: Ronald Stroethoff (stroethoff)
Date: 2011-09-11 00:20

Message:
Can you inform me for which program it is:
Scim
Scim-bridge
Scim-hangul
Scim-inputpad
Scim-m17n
scim-pinyin
scim-qtimm
scim-tables
scim-uim
they all have a version for gnome.
Besides that, yes, I am willing to accept it.

Ronald

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=650541&aid=3407286&group_id=108454