[Schrodinger-devel] motion compensation: what to do if both reference bits are set

[Wladimir v. d. L. <la...@gm...>]

Hello,

I found a possible bug, or at least, difference with the documentation, in
the motion compensation.

According subsection 8.5.5 of the specification (function pixel_pred), both
pixel values coming from the reference frames are added up in the case that
both reference frames are enabled (with weights state[ref1_weight] and
state[ref2_weight]).

I suppose these weights are picture_weight_bits, picture_weight_1 and
picture_weight_2 in Schrodinger terms.

In schro_frame_copy_with_motion, these weights are never used. Also, the
second reference block simply overwrites the first, they aren't added
together at all.

Or is only one reference frame ever used in practice, and is the
specification redundant?

Greetings,
Wladimir van der Laan