Re: [Sbcl-commits] master: De-obfuscate DEFINE-INSTRUCTION-FORMAT.

[Stas B. <sta...@gm...>]

"Douglas Katzman" <sn...@us...> writes:

> The branch "master" has been updated in SBCL:
>        via  b4b05aac3ab3e74fb26eb6ebb5e0b44f2841eaff (commit)
>       from  a14aed2ae830279710336218fbf50e049a91fbcc (commit)
>
> - Log -----------------------------------------------------------------
> commit b4b05aac3ab3e74fb26eb6ebb5e0b44f2841eaff
> Author: Douglas Katzman <do...@go...>
> Date:   Fri Feb 28 22:04:21 2014 -0500
>
>     De-obfuscate DEFINE-INSTRUCTION-FORMAT.
..
> --- a/src/compiler/ppc/insts.lisp
> +++ b/src/compiler/ppc/insts.lisp
> @@ -389,7 +389,7 @@
>  
>  (sb!disassem:define-instruction-format (xinstr 32 :default-printer '(:name :tab data))
>    (op-to-a :field (byte 16 16))
> -  (data :field (byte 16 0)))
> +  (data :field (byte 16 0) :reader xinstr-data))
>  
>  (sb!disassem:define-instruction-format (sc 32 :default-printer '(:name :tab rest))
>    (op :field (byte 6 26))
This causes DISASSEMBLE failures on ppc, XINSTR-DATA is not defined for
UNIMP-CONTROL to use. This form is wrapped in eval-when
(:compile-toplevel :execute), probably causing the issue.

-- 
With best regards, Stas.