From: David L. <da...@li...> - 2013-04-14 17:12:17
|
Quoting Mark Evenson (ev...@pa...): > I'd love to consolidate patches for running SBCL with POSIX threads on > x64 hardware for the open Solaris platforms. > > [The following (incomplete)][patches] use a GCC toolchain on an > "OpenIndiana oi151a7" platform. Sounds cool. Just a couple of questions, without having tried anything myself: - Which of the .diff files are strictly needed? All of them? Is this one logical changeset, or should it be split up into distinct bugfixes? - Why "incomplete"? - Let's please not comment out code that's out of date, just remove it entirely. - It's a bit unfortunate that we hardcode absolute paths to system binaries in Config.* files at all, so this is not a problem you've caused. :-) I have to ask anyway though: These patches change some of those paths. If we do that, let's at least make certain that the situation truly improves. So how canonical are these new locations really? Specifically, if Solaris Express has different paths than OpenIndiana, I'd personally prefer the Solaris Express paths... Thanks d. |