Re: [Sbcl-devel] QSHOW patches

[Perry E. M. <pe...@pi...>]

Christophe Rhodes <cs...@ca...> writes:
> "Perry E. Metzger" <pe...@pi...> writes:
>
>> QSHOW in the runtime is handled in a somewhat weird and idiosyncratic
>> manner -- it is generally bad style to do #if VAR rather than #ifdef.
>
> Thank you.  I've merged this into sbcl-0.8.9.43; a number of your
> other patches have also made it into HEAD in recent days.

Cool.

BTW, one problem in general is that the code in the runtime doesn't
follow a single style -- the style changes radically from file to
file, and even from section of file to section of file. Fixing this
would be a BIG change. OTOH, it would also make the code a lot easier
to read and deal with. Is this something people would like done? It
would make patches that were diffs against earlier versions of the
files almost 100% useless, so I'd say it would have to be planned
well...

As for "which style", being an old Unix geek, I'd say KNF, which is to
say BSD "Kernel Normal Form", which is a descendant of the K&R style,
but of course lots of people might disagree with this. I have an
"indent" init file that nearly does the right thing with only minimal
hand tuning after.

-- 
Perry E. Metzger		pe...@pi...