Re: [Savonet-users] download.php and wget --trust-server-name

[Damien M. <mai...@au...>]

Awesome factor = 10

I'm glad I could contribute. :-)

On 03/03/13 17:39, Romain Beauxis wrote:
> Hi Damien!
>
> I've finished the work to integrate this. However, we decided to not
> include it in the forthcoming release as it impacts too much critical
> pieces of the software.
>
> In order to test the change, you'll need to checkout or merge
> liquidsoap branch named "server-name-downloads". You will also need to
> do the whole ./bootstrap, ./configure, make and make install dance as
> the changes require a new "liquidget" program to operate.
>
> Once this is done, you should be able to activate server-name based
> downloads using this configuration variable:
>   set("extproto.use_server_name",true)
>
> Let me know if you have any issue. The pull request on github can be
> found there:
>   https://github.com/savonet/liquidsoap/pull/35/files
>
> Romain
>
> 2013/2/28 Damien Moody <mai...@au...>:
>> Nice! Yeah, that makes sense. I'm glad I could help. :-)
>>
>> On 02/27/13 17:46, Romain Beauxis wrote:
>>> Cool thanks!
>>>
>>> I will add this to the 1.1 release. However, this will only be
>>> optional because I'm not sure that the parsing of wget's log is robust
>>> enough. Logs output format could change in the future..
>>>
>>> I will thus add an option to turn this on and an option to change the
>>> default command line used to parse output..
>>>
>>> Romain
>>>
>>> 2013/2/27 Damien Moody <mai...@au...>:
>>>> Hi Romain,
>>>>
>>>> I hope this helps!
>>>>
>>>> http://forums.gentoo.org/viewtopic-p-7255706.html
>>>>
>>>> Damien
>>>>
>>>> On 02/23/13 17:30, Romain Beauxis wrote:
>>>>> Hi Damien!
>>>>>
>>>>> 2013/2/22 Damien Moody <mai...@au...>:
>>>>>> If you can try to describe how this is a problem (I believe you, I'm
>>>>>> just not quite getting it), I'll ask around. I know a couple of places
>>>>>> where people might think of something.
>>>>>>
>>>>>> Oh... I think I'm starting to get it. The filename in the URL is the
>>>>>> name used as the tmp filename, right? So that would mean wget
>>>>>> --trust-server-name and the tmp filename are two different things.
>>>>> The problem is that when liquidsoap launches the wget process, it
>>>>> needs a deterministic way to know what the temporary file's name will
>>>>> be so it can open it and play it once it's downloaded :-)
>>>>>
>>>>> When you use this feature with wget, wget never returns the downloaded
>>>>> file's name so we're completely blind..
>>>>>
>>>>> Romain