Re: [Savonet-users] [update s4shout] py/gtk GUI status and savonet interfacing

[Martin H. <ma...@so...>]

Le 27/05/2011 10:17, David Baelde a écrit :
> Hi,
>
> On Thu, May 26, 2011 at 4:37 PM, Martin Hamant<ma...@so...>  wrote:
>> So I now have a working like s4shout GUI for liquidsoap. Features are:
>> - add/remove a server (server, port, password) in the link list.
>> - start / stop for the selected link.
>> - link status are updating every x second
>> - if liquidsoap crashes (or the computer is rebooted),  at launch time,
>> s4shout reads its XML config file and populate the link list from scratch.
> That is really cool!
>
isnt'it !
>> dynamic_playlist.start pulse|server|port|password|XXXXXX
> Two remarks. First, it may not be too critical, but I would avoid
> putting the password as part of the ID; you don't need it thanks to
> the UUID component. Second, but you probably noticed that already,
> some characters will have a special treatment ("." become "(dot)" and
> spaces are not translated, resulting in unusable IDs...).

I don't understand the first point: do you mean I could send the 
password afterwards ?
For the second point, I have noticed and decided to use RFC's 4122 UUIDs 
(by using uuid4() ). This is a little brutal but it works well for now.

>> What I don't understand is if the connection fail, liquidsoap retry
>> every 3s ...  but I haven't specified any "restart" properties and it
>> seems to be "false" by default ?
> Even when restart=false, the icecast output attempts to reconnect in a
> few cases. Those should be very limited, but you may have found a bug
> here -- this wouldn't be a big surprise, this code was written before
> dynamic outputs were possible. We need to look more into that. Filing
> a bug would be a good way to make sure we don't forget.
Or... The default for restart is not false ? ll try to add a 
restart=false and see if it acts differently before filling a bug report.

> I don't have an advice for best practice. Since the status doesn't
> distinguish "retrying" for "connected" ("on" just means that the
> polling+feeding thread is active) it makes sense to disable restart
> and handle things from s4shout.
  I see ! thanks !