Re: [ruby-gnome2-devel-en] [PATCH] GtkSourceView

[Masao M. <mu...@hi...>]

Hi,

On 10 Mar 2004 14:02:01 -0500
Archit Baweja <bi...@us...> wrote:

> Hey
> 
> Masao Mutoh <mu...@hi...> writes:
> 
> > > 2) Also added bindings for gtk_source_iter_[forward|backward]_search(). See /{whatever_directory}/gtksourceview-0.7.0/docs/reference/html/gtksourceview-Searching-in-a-GtkSourceBuffer.html for what I'm talking about.
> > 
> > Hmm. 
> > The C functions are not good API design...
> > Because it should be replaced with gtk_text_iter_[forward|backward]_search().
> > #I suspect it will be merged to GtkTextIter.
> > 
> > It is better to override gtk_text_iter_[forward|backward]_search().
> > Or, at least, it should be methods of Gtk::TextIter follow gtk_text_iter_[..]_search() 
> > and have same API.
> > #I'll fix it.
> 
> Are you sure gtk_text_iter_*? Maybe you should do gtk_source_iter_* since 
> GtkSourceView search will also support regexp search later on. GtkTextIter will
> not.

So, gtk_source_iter_..._search() should *orverride* 
the Gtk::TextIter#[forward|backward]_search().
And if you can check gtksourceiter.c, you can find it can support also 
original GtkTextView.

-- 
.:% Masao Mutoh<mu...@hi...>