Re: [ruby-gnome2-devel-en] Re: [PATCH] GladeXMLSugar

[Archit B. <bi...@us...>]

Hey

Masao Mutoh <mu...@hi...> writes:

> Hi Archit,
> 
> > > The file can be found there:
> > > http://puggy.symonds.net/~bighead/ruby-libglade-sugar-patch-pre1.diff
> 
> I checked it, and have some questions/comments.
> 
> * GladeXml#widget_names
>   Good feature.
>   But REXML is NOT standard library in ruby-1.6.x.
>   
>   And I think it's not so difficult to get ids from glade file
>   without any XML parser. Could you re-write it without REXML?

Hmm do-able. I'll see what I can churn up. Probably a simple regexp search
through a file.

> 
> * GladeXMLSugar
>   Interesting. But I think it makes some restriction of the ids.
>   e.g.) need to avoid the ids like as "class", "name", "new", 
>   "constants", .... 
>   So I don't apply this feature now.
>   # And also I don't like the name, though it's a small issue.
> 

Well I couldn't think of any name at that moment, but I have a new one.
GladeXMLHelper.

And there is also the question of how to actually use it. By that I mean we
could have it as :-

1) it is rightnow, a class (which btw should be a pure virtual class, I
don't know how to do that in Ruby as yet). 

2) We could make it a module which people can mixin and run the specified
method.

module GladeXMLHelper
        def get_widget_refs ()
                # The code....
        end
end

class myui
        include GladeXMLHelper
        def initialize ()
                get_widget_refs ()
                # Rest of code....
        end
        #...
end

This will also help in that in the future, if we add more helper fucntions, 
they can all go in this Helper module, for which people have to require (maybe?)
I'll try and get back to you on a new GladeXML#widget_names patch.

Cheers!
Archit