Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding elements and pads

[Kouhei S. <ko...@co...>]

Hi,

In <200...@sp...>
  "Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding elements and pads" on Sun, 30 Mar 2008 11:35:32 +0200,
  Sjoerd Simons <sj...@lu...> wrote:

> > > You mentioned this on all my patches. But as i'm still unclear what the exact
> > > coding style is i'm guessing from various files and it seems i'm guessing wrong
> > > :) It would really help me if you could write some basic definition of your
> > > preferred coding style.
> > 
> > Does this mean "I can't read source codes written by
> > others", "I don't want to read source codes written by
> > others carefully" or "I don't want to follow your
> > coding-style"? If this is true, unfortunately we will not be
> > able to work on the same project.
> 
> It means none of the above. It means that as far as i can tell the patch i've
> attached in this thread follows the coding style which is in most other
> rubyg-gnome2 files (excluding ruby/gstreamer as that's mostly a mess). But
> apparently i got some details wrong. So please instead of telling me that
> something is wrong, tell me what is wrong so i can fix it and improve it in the
> other patches too.

OK. I will trust you once.

You can commit your patches that I've reviewed without
fixing your style. I'll fix your style after you commit.
But you need to check my fixes, learn from my commits and
follow our coding-style in the feature commit. OK?


Thanks,
--
kou