From: Sjoerd S. <sj...@lu...> - 2008-03-30 00:29:32
|
On Sun, Mar 30, 2008 at 09:04:23AM +0900, Kouhei Sutou wrote: > Hi, > > In <200...@sp...> > "Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding elements and pads" on Sat, 29 Mar 2008 22:14:51 +0100, > Sjoerd Simons <sj...@lu...> wrote: > > > > See attached patch. > > > > Which contained some typos, updated patch attached > > It was very happy for us if you considered to follow our > coding-style. You mentioned this on all my patches. But as i'm still unclear what the exact coding style is i'm guessing from various files and it seems i'm guessing wrong :) It would really help me if you could write some basic definition of your preferred coding style. > > + if (!rb_obj_is_kind_of (element, klass)) { > > Use RVAL2CBOOL not !. Actually the ruby interpreter code itself uses !rb_obj_is_kind_of too, but i'll change this :) Sjoerd -- If I have not seen so far it is because I stood in giant's footsteps. |