From: Guillaume C. <gco...@gm...> - 2007-07-13 14:29:23
|
On 7/13/07, Masao Mutoh <mu...@hi...> wrote: > Hi > > On Fri, 13 Jul 2007 14:10:55 +0200 > "Guillaume Cottenceau" <gco...@gm...> wrote: > > > I've counted 88 uses of RVAL2CBOOL and 401 uses of RTEST in the code. > > As RVAL2CBOOL is defined to use RTEST, I think we should should choose > > either one, and then use only one form. RTEST is more rubyish but > > RVAL2CBOOL makes sense as long as we also use CBOOL2RVAL. > > > > What do you think? > > RVAL2CBOOL is better. May I go ahead and substitute all uses of RTEST by uses of RVAL2CBOOL? -- Guillaume Cottenceau - http://zarb.org/~gc/ |