#99 Segfault on searching terminal with scrollback

[Omega Weapon]

When searching in the terminal for a string (Search -> Find...), if the terminal has more than one page stored in its scrollback (it seems), any search segfaults. I have attached a full backtrace when this happens - output up to that point from gdb:

(roxterm:18798): Gtk-WARNING **: Error loading icon from file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg':
    Failed to open file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg': No such file or directory
[New Thread 0x7fffeca0e700 (LWP 18819)]
[New Thread 0x7fffe7fff700 (LWP 18820)]
[New Thread 0x7fffe77fe700 (LWP 18821)]
[New Thread 0x7fffe69cd700 (LWP 18825)]
[Thread 0x7fffe7fff700 (LWP 18820) exited]
[Thread 0x7fffe77fe700 (LWP 18821) exited]

(roxterm:18798): Gtk-WARNING **: /tmp/buildd/gtk+2.0-2.24.22/gtk/gtktreemodel.c:1464: Invalid column number 6540048 accessed (remember to end your list of columns with a -1)

** (roxterm:18798): WARNING **: Unable to load logo for about dialog: Failed to open file '/usr/local/share/icons/hicolor/scalable/apps/roxterm.svg': No such file or directory

(roxterm:18798): Gtk-WARNING **: /tmp/buildd/gtk+2.0-2.24.22/gtk/gtktreemodel.c:1464: Invalid column number 6540048 accessed (remember to end your list of columns with a -1)

(roxterm:18798): GLib-GObject-WARNING **: can't peek value table for type `gint64' which is not currently referenced

(roxterm:18798): GLib-GObject-WARNING **: /tmp/buildd/glib2.0-2.36.4/./gobject/gvalue.c:190: cannot initialize GValue with type `gint64', this type has no GTypeValueTable implementation

(roxterm:18798): Gtk-WARNING **: /tmp/buildd/gtk+2.0-2.24.22/gtk/gtktreedatalist.c:180: Unsupported type ((null)) retrieved.

(roxterm:18798): GLib-GObject-WARNING **: /tmp/buildd/glib2.0-2.36.4/./gobject/gtype.c:4239: type id `0' is invalid

(roxterm:18798): GLib-GObject-WARNING **: can't peek value table for type `<invalid>' which is not currently referenced

Program received signal SIGSEGV, Segmentation fault.

I originally noticed this in Debian's v2.7.2, the above failure is from a freshly built git pull. (ROXTerm 2.7.2.16~gddadff1).

[Tony Houghton]

I couldn't reproduce the crashes but I got the warnings about invalid column numbers and it looks like you crashed in the same function. I've fixed that call and pushed it to git, hopefully this will cure the crashing for you as well as the warnings.

Did you run roxterm directly from the build tree without installing it? That would explain the missng SVG.

[Omega Weapon]

Thankyou - I have just installed for real and tested, no segfaults!

Yes, that was just an artefact of the testing.

I don't suppose you could bind Cntrl+SHIFT+F to 'Find', F3 to 'Find Next' and SHIFT+F3 to 'Find Previous'?

[Tony Houghton]

You can change them yourself. Enable shortcut editing in the config manager then change them by pressing the keys while the mouse is over a menu item.

[Omega Weapon]

Excellent, thanks!