From: Thomas L. <ta...@ec...> - 2003-01-02 19:30:03
|
Hi everyone! Translaters and testers: I'll probably release 1.3.6 a few days from now. The new List View is the big change this time, and is probably still slightly buggy... please test it!! There are a number of other changes, including: - New options box layout - Button to purge the thumbnails cache - Better icon size changing - Recently modified items shown in bold - New sort types, and Reverse option - Auto resizing when mounting/unmounting - Iconified windows always have a button appearance - Minor sorting changes The snapshots have been updated: http://rox.sourceforge.net/snapshots/ Enjoy! -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Thomas L. <ta...@ec...> - 2003-02-22 20:50:17
|
I'm planning to make a new filer release in a few days, so now would be a good time to update the translations. There are still a few bugs to work out (check the TODO file), but I think that's the last of the new features. And yes, you may start testing now ;-) -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Laurent M. <lau...@9o...> - 2003-02-23 23:12:33
|
Thomas Leonard: > I'm planning to make a new filer release in a few days, so now would > be a good time to update the translations. There are still a few > bugs to work out (check the TODO file), but I think that's the last > of the new features. And yes, you may start testing now ;-) I just compiled the filer from cvs, there seem to be a new bug: the pinboard appears only on the first desktop (when using an EWMH window manager, not the "override-wm" compatibility mode). In fact the pinboard window seems to be mapped without any _NET_WM_DESKTOP (whereas it has _NET_WM_DESKTOP=#FFFFFFFF before). I think this is a recent problem (the cvs version did not have this problem a few days ago). -- Laurent Moussault |
From: Yuri B. <yu...@so...> - 2003-02-24 14:52:49
|
Il giorno Sat, Feb 22, 2003 at 08:45:30PM +0000, Thomas Leonard ha scritto: > I'm planning to make a new filer release in a few days, so now would be a > good time to update the translations. There are still a few bugs to work > out (check the TODO file), but I think that's the last of the new > features. And yes, you may start testing now ;-) I'm updating italian translation, but this week I'm quite busy. I'll send it to you next time. Bye :) Yuri |
From: Thomas L. <ta...@ec...> - 2003-03-09 19:03:43
|
On Mon, Feb 24, 2003 at 12:11:07AM +0100, Laurent Moussault wrote: > Thomas Leonard: > > > I'm planning to make a new filer release in a few days, so now would > > be a good time to update the translations. There are still a few > > bugs to work out (check the TODO file), but I think that's the last > > of the new features. And yes, you may start testing now ;-) > > I just compiled the filer from cvs, there seem to be a new bug: the > pinboard appears only on the first desktop (when using an EWMH window > manager, not the "override-wm" compatibility mode). > > In fact the pinboard window seems to be mapped without any > _NET_WM_DESKTOP (whereas it has _NET_WM_DESKTOP=#FFFFFFFF before). > > I think this is a recent problem (the cvs version did not have this > problem a few days ago). Does this still happen? There were some GTK+-2.2 changes that stopped this working for a while, but it seems to be OK here. -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Laurent M. <lau...@9o...> - 2003-03-10 16:07:54
|
Thomas Leonard: > Laurent Moussault wrote: > > > In fact the pinboard window seems to be mapped without any > > _NET_WM_DESKTOP (whereas it has _NET_WM_DESKTOP=#FFFFFFFF before). > > > > I think this is a recent problem (the cvs version did not have > > this problem a few days ago). > > Does this still happen? There were some GTK+-2.2 changes that > stopped this working for a while, but it seems to be OK here. Yes, it still does. (I've just updated from cvs, and I use gtk 2.2.1). The problem seems to be at the end of the 'create_pinboard_window' function (in 'pinboard.c'). I've done some "printf debugging", and before the call to: gtk_widget_show_all(win); The _NET_WM_DESKTOP property is correctly set to -1 (since the 'make_panel_window' call), but after this function the property is not set anymore... This is strange because panels windows don't have this problem (their desktop property is set to -1). Don't they use the same function? (my gtk knowledge is very limited) Note that depending on the WM, the final result is not exactly the same: IceWM set the property to 0, but still show the pinboard on all desktops, while Metacity set the property back to -1 (after the call to 'gdk_window_lower'). Without any WM running the property just disappear. I've added a work around in Framer anyway, and since the pinboard seems to work on the other EWMH wms (didn't test with blaclbox), I think the better is to wait a bug fix in GTK... -- lau...@la... |
From: Thomas L. <ta...@ec...> - 2003-03-28 10:35:02
|
CVS snapshots are ready for the next release. Please test! http://rox.sourceforge.net/snapshots/ This release has a number of bug fixes, improvements to the panel, allows dragging files to text fields (to insert the name), faster selections in List View, and stock icons in the menus. See the Changes file for a list of things to test. I'll probably do a release in a few days, after the translators have had a chance... -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Joe H. <jo...@sy...> - 2003-03-28 23:02:55
|
Wow, nice. The panel resizing works perfect, really cool. I'll do some testing tonight. Thanks Thomas, once again. You made my day. On Fri, 28 Mar 2003 10:32:29 +0000 Thomas Leonard <ta...@ec...> wrote: > CVS snapshots are ready for the next release. Please test! > > http://rox.sourceforge.net/snapshots/ > > This release has a number of bug fixes, improvements to the panel, > allows dragging files to text fields (to insert the name), faster > selections in List View, and stock icons in the menus. See the Changes > file for a list of things to test. > > I'll probably do a release in a few days, after the translators have had a > chance... > > > -- > Thomas Leonard http://rox.sourceforge.net > ta...@ec... ta...@us... > GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 > > > ------------------------------------------------------- > This SF.net email is sponsored by: > The Definitive IT and Networking Event. Be There! > NetWorld+Interop Las Vegas 2003 -- Register today! > http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en > _______________________________________________ > rox-devel mailing list > rox...@li... > https://lists.sourceforge.net/lists/listinfo/rox-devel -- - Joe "When the going gets weird, the weird turn pro." - H.S.T. |
From: Thomas L. <ta...@ec...> - 2003-05-15 14:30:17
|
The bugs list is now empty (mainly because I moved some of them to 2.1 ;-), so the next release will be a stable release candidate. CVS snapshots are here: http://rox.sourceforge.net/snapshots/ Main changes to test: - New Japanese translation - When a directory change is detected, wait a little before rescanning to reduce flickering effect - Updated install script to use new XDG Base Directory spec - Close stdout when running child processes - Using the bookmarks menu to open an unmounted mount point will mount it - Updates for the new shared MIME database - Remove default GtkTreeView keys (they conflicted with the menus) - Lasso selections and the winking effect now work in List view -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Keith R. J. W. <kr...@op...> - 2003-05-15 14:51:09
|
* Thomas Leonard <ta...@ec...> [15/05/2003 1026EDT]: > > - Updated install script to use new XDG Base Directory spec > Aha. One thing I would like to see with this install script is the use of ${DESTDIR} to facilitate the building of RPM packages, and possibly options to run the install script in a non-interactive mode... -- Keith R. John Warno [k r j w at optonline dot net] |
From: Thomas L. <ta...@ec...> - 2003-05-15 15:38:10
|
On Thu, May 15, 2003 at 10:51:00AM -0400, Keith R. John Warno wrote: > * Thomas Leonard <ta...@ec...> [15/05/2003 1026EDT]: > > > > - Updated install script to use new XDG Base Directory spec > > > > Aha. One thing I would like to see with this install script is the use > of ${DESTDIR} to facilitate the building of RPM packages, and possibly > options to run the install script in a non-interactive mode... Does the RPM build process need install.sh at all? It only copies a few files around... a simple copy operation would do just as well. -- Thomas Leonard http://rox.sourceforge.net ta...@ec... ta...@us... GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Keith R. J. W. <kr...@op...> - 2003-05-15 20:35:53
|
* Thomas Leonard <ta...@ec...> [15/05/2003 1132EDT]: > On Thu, May 15, 2003 at 10:51:00AM -0400, Keith R. John Warno wrote: > > * Thomas Leonard <ta...@ec...> [15/05/2003 1026EDT]: > > > > > > - Updated install script to use new XDG Base Directory spec > > > > > > > Aha. One thing I would like to see with this install script is the use > > of ${DESTDIR} to facilitate the building of RPM packages, and possibly > > options to run the install script in a non-interactive mode... > > Does the RPM build process need install.sh at all? It only copies a few > files around... a simple copy operation would do just as well. Good point. :) they are appdirs afterall... -- Keith R. John Warno [k r j w at optonline dot net] "It's your money. You paid for it." -- George "Dubuhyuh" Bush, LaCrosse, Wis., Oct. 18, 2000 |
From: Thomas L. <ta...@ec...> - 2004-01-21 20:09:21
|
Hopefully I'll release ROX-Filer 2.1.1 after a few days. This is advance warning for translators! Also, I've made a few last minute changes... could someone (Stephen?) check the 'cvs diff -D yesterday' (especially the xattr stuff, which I can't test). (what were the errno=0 bits for?) Thanks, -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Stephen W. <st...@ke...> - 2004-01-21 21:54:32
|
Thomas Leonard <ta...@ec...> wrote: >(what were the errno=0 bits for?) Just a debugging aid, I think. -- Stephen Watson http://www.kerofin.demon.co.uk/ I woke up and I had a big idea/To buy a new soul at the start of every year I paid up and it cost me pretty dear/Here's a hymn to those that disappear |
From: Thomas L. <ta...@ec...> - 2004-07-30 14:09:33
|
There will probably be a new filer release in a couple of days. Please test the snapshot and report problems: $ 0refresh "www.ecs.soton.ac.uk#~tal" $ "/uri/0install/www.ecs.soton.ac.uk#~tal/rox" -n You can also get the latest version from CVS: http://rox.sourceforge.net/phpwiki/index.php/Using%20CVS -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Vincent L. <vi...@vi...> - 2004-07-30 14:41:26
|
On 2004-07-30 15:06:01 +0100, Thomas Leonard wrote: > There will probably be a new filer release in a couple of days. I've updated the CVS, and install.sh gives the following error when compiling: [...] gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o abox.o /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function `abox_finalise': /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:337: warning: implicit declaration of function `gtk_timeout_remove' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function `abox_set_current_object': /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:374: warning: implicit declaration of function `gtk_timeout_add' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function `abox_add_combo': /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:516: warning: implicit declaration of function `gtk_combo_new' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:516: warning: assignment makes pointer from integer without a cast /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:517: warning: implicit declaration of function `gtk_combo_disable_activate' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:517: warning: implicit declaration of function `GTK_COMBO' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:518: warning: implicit declaration of function `gtk_combo_set_use_arrows_always' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:519: warning: implicit declaration of function `gtk_combo_set_popdown_strings' /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:520: error: invalid type argument of `->' make: *** [abox.o] Error 1 Compile failed I don't know if some dev files are missing, in which case, configure should return an error. -- Vincent Lefèvre <vi...@vi...> - Web: <http://www.vinc17.org/> 100% validated (X)HTML - Acorn / RISC OS / ARM, free software, YP17, Championnat International des Jeux Mathématiques et Logiques, etc. Work: CR INRIA - computer arithmetic / SPACES project at LORIA |
From: Guido S. <__g...@we...> - 2004-07-30 15:16:23
|
Am 30.07.2004 16:41:12 schrieb(en) Vincent Lefevre: > On 2004-07-30 15:06:01 +0100, Thomas Leonard wrote: > > There will probably be a new filer release in a couple of days. > > I've updated the CVS, and install.sh gives the following error when > compiling: > > [...] > gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall > -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 > `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o abox.o > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function > `abox_finalise': > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:337: warning: > implicit declaration of function `gtk_timeout_remove' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function > `abox_set_current_object': > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:374: warning: > implicit declaration of function `gtk_timeout_add' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c: In function > `abox_add_combo': > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:516: warning: > implicit declaration of function `gtk_combo_new' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:516: warning: > assignment makes pointer from integer without a cast > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:517: warning: > implicit declaration of function `gtk_combo_disable_activate' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:517: warning: > implicit declaration of function `GTK_COMBO' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:518: warning: > implicit declaration of function `gtk_combo_set_use_arrows_always' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:519: warning: > implicit declaration of function `gtk_combo_set_popdown_strings' > /home/lefevre/software/rox/rox/ROX-Filer/src/abox.c:520: error: > invalid type argument of `->' > make: *** [abox.o] Error 1 > Compile failed > > I don't know if some dev files are missing, in which case, configure > should return an error. That's because GTK_COMBO is deprecated in gtk-2.4.x. You have to compile with -DGTK_ENABLE_DEPRECATED. ROX-Filer should detect gtk-2.4 and set this flag automatically, but it doesn't, so I edit the Makefile after the configure step (interrupting the build and restarting with issuing "make" from with "src". The cleanest solution of course would be to get rid of the deprecated widgets. No idea how much work this is. Apropos, ROX-Lib2 needs an upgrade for the latest gtk as well. With pygtk-2.3.94 I get this with my Contacts app (there will be a new release soon): /boot/home/Apps/Contacts/ContactWindow.py:43: DeprecationWarning: toolbar.insert_stock(g.STOCK_HELP, _('Help'), None, self.help, None, 0) /boot/home/Apps/Contacts/ContactWindow.py:50: DeprecationWarning: None, 0) /boot/home/Apps/Contacts/ContactWindow.py:51: DeprecationWarning: toolbar.insert_stock(g.STOCK_FIND, _('Search'), None, self.search, None, 0) /boot/home/Apps/Contacts/ContactWindow.py:52: DeprecationWarning: toolbar.insert_stock(g.STOCK_SAVE, _('Save Card'), None, self.save, None, 0) /boot/home/Apps/Contacts/ContactWindow.py:53: DeprecationWarning: toolbar.insert_stock(g.STOCK_NEW, _('New Card'), None, self.new, None, 0) /boot/home/Apps/Contacts/gtk-2.0/gtk/__init__.py:85: GtkDeprecationWarning: gtk.mainloop is deprecated, use gtk.main instead self.warn(message, DeprecationWarning) /boot/home/Apps/Contacts/gtk-2.0/gtk/__init__.py:85: GtkDeprecationWarning: gtk.mainquit is deprecated, use gtk.main_quit instead self.warn(message, DeprecationWarning) |
From: Tony H. <h...@re...> - 2004-07-30 16:26:37
|
In <1091200685l.31786l.0l@RoxOS>, Guido Schimmels wrote: > That's because GTK_COMBO is deprecated in gtk-2.4.x. > You have to compile with -DGTK_ENABLE_DEPRECATED. ROX-Filer should > detect gtk-2.4 and set this flag automatically, but it doesn't, so I > edit the Makefile after the configure step (interrupting the build and > restarting with issuing "make" from with "src". > The cleanest solution of course would be to get rid of the deprecated > widgets. No idea how much work this is. My tgauge applet has a couple of files called easycombo.h/c presenting the same API for combos to the rest of the program whether you've got GTK+ 2.2 or 2.4, using GtkOptionMenu or GtkComboBox respectively. I think ROX did officially drop support for 2.2 recently though, in that case it would be better for it to use GtkComboBox directly. -- TH * http://www.realh.co.uk |
From: Stephen W. <st...@ke...> - 2004-07-30 16:43:10
|
Tony Houghton <h...@re...> wrote: > I think ROX did officially drop support for 2.2 recently though, in that > case it would be better for it to use GtkComboBox directly. It was 2.0 support that was dropped, 2.2 is the base release the Filer needs. -- Stephen Watson http://www.kerofin.demon.co.uk/ If you read this on a mailing list, send any reply back to the list and not to me. Not even CC. |
From: Thomas L. <ta...@ec...> - 2004-07-30 17:14:46
|
On Fri, Jul 30, 2004 at 03:18:05PM +0000, Guido Schimmels wrote: > Am 30.07.2004 16:41:12 schrieb(en) Vincent Lefevre: > >On 2004-07-30 15:06:01 +0100, Thomas Leonard wrote: > >> There will probably be a new filer release in a couple of days. > > > >I've updated the CVS, and install.sh gives the following error when > >compiling: > > > >[...] > That's because GTK_COMBO is deprecated in gtk-2.4.x. > You have to compile with -DGTK_ENABLE_DEPRECATED. ROX-Filer should > detect gtk-2.4 and set this flag automatically, but it doesn't, so I > edit the Makefile after the configure step (interrupting the build and > restarting with issuing "make" from with "src". OK, I've changed config.h.in to set this. Might take a while to show up in anon CVS. The version of GTK 2.4 in Debian doesn't require this though (and it's a bit strange to disallow deprecated widgets by default). Once the changes appear in CVS, could you check it works for you? > The cleanest solution of course would be to get rid of the deprecated > widgets. No idea how much work this is. Then it wouldn't compile with GTK 2.2, which is no good for us. > Apropos, ROX-Lib2 needs an upgrade for the latest gtk as well. > With pygtk-2.3.94 I get this with my Contacts app (there will be a new > release soon): > > /boot/home/Apps/Contacts/ContactWindow.py:43: DeprecationWarning: > toolbar.insert_stock(g.STOCK_HELP, _('Help'), None, self.help, None, > 0) Doesn't seem to be a ROX-Lib problem there (although there probably are some somewhere). I can't test it here, but please submit a patch... Luckily, the zero install version of pygtk is always the same version, so everyone using that should be OK :-) -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Vincent L. <vi...@vi...> - 2004-07-30 19:20:04
|
On 2004-07-30 18:11:18 +0100, Thomas Leonard wrote: > OK, I've changed config.h.in to set this. Might take a while to show > up in anon CVS. The version of GTK 2.4 in Debian doesn't require > this though (and it's a bit strange to disallow deprecated widgets > by default). What do you mean by "doesn't require this"? The failed compilation was on a Debian machine (unstable), with: greux:~> pkg-config --modversion gtk+-2.0 2.4.4 > Once the changes appear in CVS, could you check it works for you? I've just done a checkout of the :ext: CVS on another machine (Debian testing/unstable, PowerPC), with ay:~> pkg-config --modversion gtk+-2.0 2.4.3 and I don't get the error. However... [...] gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o mount.o /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c: In function `mount_get_fs_size': /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: `buf' undeclared (first use in this function) /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: (Each undeclared identifier is reported only once /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: for each function it appears in.) make: *** [mount.o] Error 1 Compile failed -- Vincent Lefèvre <vi...@vi...> - Web: <http://www.vinc17.org/> 100% validated (X)HTML - Acorn / RISC OS / ARM, free software, YP17, Championnat International des Jeux Mathématiques et Logiques, etc. Work: CR INRIA - computer arithmetic / SPACES project at LORIA |
From: Thomas L. <ta...@ec...> - 2004-07-31 16:20:16
|
On Fri, Jul 30, 2004 at 09:19:47PM +0200, Vincent Lefevre wrote: > On 2004-07-30 18:11:18 +0100, Thomas Leonard wrote: > > OK, I've changed config.h.in to set this. Might take a while to show > > up in anon CVS. The version of GTK 2.4 in Debian doesn't require > > this though (and it's a bit strange to disallow deprecated widgets > > by default). > > What do you mean by "doesn't require this"? The failed compilation was > on a Debian machine (unstable), with: > > greux:~> pkg-config --modversion gtk+-2.0 > 2.4.4 Odd. Doesn't happen here (same version). In fact, I can't see any reference to GTK_ENABLE_DEPRECATED: $ grep -r GTK_ENABLE_DEPRECATED /usr/include/gtk-2.0/ $ [...] > gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o mount.o /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c: In function `mount_get_fs_size': > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: `buf' undeclared (first use in this function) Looks like the compile error has been fixed. But... won't it just print random numbers now? -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Stephen W. <st...@ke...> - 2004-07-31 16:39:16
|
Thomas Leonard <ta...@ec...> wrote: > On Fri, Jul 30, 2004 at 09:19:47PM +0200, Vincent Lefevre wrote: > > gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o mount.o /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c > > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c: In function `mount_get_fs_size': > > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: `buf' undeclared (first use in this function) > > Looks like the compile error has been fixed. But... won't it just print > random numbers now? No, because: gchar *mount_get_fs_size(const gchar *dir) { int ok=FALSE; #if defined(HAVE_STATVFS) struct statvfs buf; #elif defined(HAVE_STATFS) struct statfs buf; #endif unsigned long long total, used, avail; gdouble fused; gchar *str; gchar *tmp1, *tmp2; #if defined(HAVE_STATVFS) ok=statvfs(dir, &buf)==0; #elif defined(HAVE_STATFS) ok=statfs(dir, &buf)==0; #endif if(!ok) return NULL; ok must be FALSE if neither statvfs or statfs are called. -- Stephen Watson http://www.kerofin.demon.co.uk/ If you read this on a mailing list, send any reply back to the list and not to me. Not even CC. |
From: Vincent L. <vi...@vi...> - 2004-07-31 17:52:10
|
On 2004-07-31 17:16:34 +0100, Thomas Leonard wrote: > > gcc -I. -I/home/lefevre/software/rox/rox/ROX-Filer/src -g -O2 -Wall -Wmissing-prototypes -I/usr/X11R6/include -D_FILE_OFFSET_BITS=64 `pkg-config --cflags gtk+-2.0 libxml-2.0` -c -o mount.o /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c > > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c: In function `mount_get_fs_size': > > /home/lefevre/software/rox/rox/ROX-Filer/src/mount.c:363: error: `buf' undeclared (first use in this function) > > Looks like the compile error has been fixed. But... won't it just > print random numbers now? gchar *mount_get_fs_size(const gchar *dir) { int ok=FALSE; #if defined(HAVE_STATVFS) struct statvfs buf; #elif defined(HAVE_STATFS) struct statfs buf; #endif unsigned long long total, used, avail; gdouble fused; gchar *str; gchar *tmp1, *tmp2; #if defined(HAVE_STATVFS) ok=statvfs(dir, &buf)==0; #elif defined(HAVE_STATFS) ok=statfs(dir, &buf)==0; #endif if(!ok) return NULL; #if defined(HAVE_STATVFS) total=buf.f_frsize*(unsigned long long) buf.f_blocks; used=buf.f_frsize*(unsigned long long) (buf.f_blocks-buf.f_bfree); avail=buf.f_frsize*(unsigned long long) buf.f_bavail; #else total=buf.f_bsize*(unsigned long long) buf.f_blocks; used=buf.f_bsize*(unsigned long long) (buf.f_blocks-buf.f_bfree); avail=buf.f_bsize*(unsigned long long) buf.f_bavail; #endif I assume that the #else should be replaced by #elif defined(HAVE_STATFS) C is a silly language... -- Vincent Lefèvre <vi...@vi...> - Web: <http://www.vinc17.org/> 100% validated (X)HTML - Acorn / RISC OS / ARM, free software, YP17, Championnat International des Jeux Mathématiques et Logiques, etc. Work: CR INRIA - computer arithmetic / SPACES project at LORIA |
From: Stephen W. <st...@ke...> - 2004-07-31 18:09:32
|
Vincent Lefevre <vi...@vi...> wrote: > I assume that the #else should be replaced by > > #elif defined(HAVE_STATFS) I put that fix in last night. I'm quite suprised that neither statfs or statvfs were found. What platform was this? -- Stephen Watson http://www.kerofin.demon.co.uk/ If you read this on a mailing list, send any reply back to the list and not to me. Not even CC. |