Re: [Rosegarden-devel] note names ?

[Chris C. <ca...@al...>]

Guillaume Laurent wrote:

> it seems we don't have note names anywhere.


What sort of note names?  We have NotationDisplayPitch::getAsString
in base/, or the MidiPitchLabel class in sound/ if going through
display pitches seems like a distraction.


> A problem is that they can't be in base, because we need to make them 
> translatable, which relies on KDE.

I don't know what goes on behind the i18n macro or function, but
can't you just call it on whatever string you get back from your
call to the base code?  No translation support in base, but only
in the code that calls it?

Of course ideally the names should depend on the clef and key as
well -- the code in NotationDisplayPitch is arguably wrong for
this kind of purpose as it shows the "MIDI pitch name" which is
only the same thing as the name of the note if you happen to be
in C major and the treble clef.


Chris