[Rosegarden-devel] tr() vs. QObject::tr() in rev 14211

[D. M. M. <ros...@gm...>]

 > Also added a few new strings to translate. These were already in the
 > code, but weren't wrapped with tr() calls.

Looks like your thought process went something like:

1. Find string not wrapped in tr() call
2. Wrap new string in tr() call
3. Notice all the QObject::tr() weirdness elsewhere
4. Make everything uniform by changing it all to tr()

I no longer remember every detail, but getting the translations to work 
was a very arduous and labor-intensive process.  I translated hundreds, 
maybe thousands of things that had never been translated before, and I 
tested everything.

My gut feeling combined with testing to verify my original solution was 
still working left me inclined to revert to my original solution without 
testing your proposed alternative.  Qt is funny about translation 
contexts.  If you use tr() in the wrong places, it will compile, the 
strings will show up in the .ts file, but the user will never see them 
at runtime.

I added the new strings though.  No problem there.  Everything should be 
updated and fully translated again, unless I did something stupid, in a 
rush.
-- 
D. Michael McIntyre