From: Tom B. (Tehom) <te...@pa...> - 2013-07-20 15:58:28
|
> > After an upgrade to Qt 4.8.5 I didn't see any significant difference. > (Only one difference: no more black rectangle in the matrix.) > > Le samedi, juillet 20, 2013 � 03:39:36 AM, Tom Breton (Tehom) a �crit : >>> Le vendredi, juillet 19, 2013 � 07:04:48 PM, Tom Breton (Tehom) >>> a > >>So I wondered if maybe Logarithmic was calculating crazy timeRatios and >>therefore making us scribble events outside the proper time interval. >>That shouldn't screw up the display like that, though. It doesn't for >>other insert-event-at-crazy-time bugs. > > Looking in the code, I discovered the problem was indeed here. I'm cc-ing Tim Munro. That bit of code (the Logarithmic calculations) is from his patch so he should be in the loop. > When ramp start value end end value are the same, the timeRation computed > is a nan (0/0) (at > least on my system) and all the events are inserted at time > -9223372036854775808 which gave > the strange GUI behaviour I observed. > > I have no idea why I was the only one to see the problem. Possibly your compiler handles floating point or NaN differently? > I just commited a fix which seems to work here (with Qt 4.7.4 as with Qt > 4.8.5). Thank you. It changes the other branches' logic a little. If you don't mind, I'm going to write a slightly different fix. > I didn't test it extensively. So thanks to verify I didn't break anything. I will. Tom Breton (Tehom) |