Re: [Rosegarden-devel] [12366] trunk/rosegarden/src/gui/general/ ProjectPackager.cpp

[Ted F. <te...@te...>]

On 8/28/2011 12:26 PM, D. Michael McIntyre wrote:
>> Import/Export Rosegarden Package Fixes
>>
>> - Fixed a bug where all audio files would be lost in the .rg file when
>>    exporting to a rosegarden package (.rgp).
> Would you mind giving a bit of explanation what the bug was, and what was
> required to fix it?

   The names in usedAudioFiles were all full path names while the names 
in the <audio> tags were just base names.  So, I used QFileInfo to 
reduce the names in usedAudioFiles down to their base names.  This way 
it would properly identify that the audio files were being used.  Before 
this change, the .rg files that were created (for me anyway) had all the 
<audio> tags removed and therefore all the audio segments were missing.

> I do wonder why you changed all the RG_DEBUG lines to start at the far 
> left.

   Old habit from many years ago.  Putting debug output statements to 
the far left serves two purposes:

1. Debug output tends to be rather verbose.  So if it wanders too far to 
the right, it becomes difficult to keep it within an 80 column limit.

2. Debug output tends to be needed only temporarily.  Putting it far 
left makes it easy to spot and remove.

   Finally, debug output isn't generally an important part of the code 
(for the few times when it is, I indent it).  Moving it to the left in 
effect gets it visually out of the way.  Of course, if you're not used 
to it, it's quite an eyesore.

   Anyway, sorry to rock the boat.  Let me know what the project 
standard is and I'll stick to it.

Ted.