[Rosegarden-devel] Patch - triggered segments

[Ian G. <ilg...@ya...>]

Hello Julie,

Following on from last week, here's that patch containing some fixes/adjustments I've come up with while playing around with the triggered segment functionality. I've tried to explain what I've done below, so you can pick and choose which bits of the patch you want to take.

TriggeredSegmentManager.cpp: change to line connecting up m_listView's double click signal seems to reenable the double click to bring up the event list editor. Also the patch as written un-disables the "Add" button on the dialog. It seems to me like the Add button is useful, although I'm prepared to be guided by you all on that one.

eventlist.rc: change in this file seems to reenable pasting into the event list editor.

EventListView.{h,cpp}: Changes I've made to these files are a bit more experimental and probably require a bit more thought (or ignoring, I shall not be offended!). 

1) There was non-functioning code which looked like it was intended to bring up a context menu. I wrote something which connects it all up again in a Qt4 kind of way - you can have a chuckle at my attempts! Looks like that context menu handling function could do with factoring away anyway, it substantially repeats code elsewhere in that file, but as a like-for-like replacement of the RG classic functionality I think its defensible.

2) As an "interesting suggestion" I un-disabled the ability to open a triggered segment in the matrix or notation editors. This meant I was able to use the add button in the triggered segment manager to add an empty segment, then open that segment in the notation editor (via the event list editor) to add content to the triggered segment directly (rather than doing an event list copy/paste op). One weakness of this is that the notation/matrix editor isn't aware that it's displaying a triggered segment, so when you press play the play head moves over the notes as if it's a real segment but of course totally unrelated sound comes out.

Hope at least some of these changes are useful or of interest!

Cheers,

Ian.