From: Chris C. <ca...@al...> - 2008-10-02 14:29:38
|
On Thu, Oct 2, 2008 at 3:22 PM, Emanuel Rumpf <xb...@gm...> wrote: > If it's a non-fix, where is addAction implemented then ?? EditViewCommandRegistry (the subclass). But, please hold off on any more action-related fixes until we've decided how to go ahead with actions generally (please do see, and reply to, my messages on the devel list this morning). I'm concerned that making ad-hoc changes from the old KAction constructor call (which at least had all the necessary information in a single place) to multi-line QAction construction and property setups may only be making it harder to carry out a nice uniform transfer to a new mechanism, once we've decided what that should actually be. Don't forget that all the work of putting actions into menus and making sure they appear was carried out by KXMLGUI, not by our code explicitly, so simply translating KAction to QAction won't actually make any working menus. I'd rather do all this once (it is my current to-do item on the wiki) and get it right. Chris |