Re: [Rosegarden-devel] Patch for "quick marker"

[Philippe M. <phi...@gm...>]

On Mon, Mar 10, 2008 at 3:29 PM, D. Michael McIntyre
<mic...@ro...> wrote:
>  > By the way, if you think that the full-blown "marker shortcut" (a
>  > keyboard accelerator associated with a named-marker to move the cursor
>  > from the main window) patch can be of use to anybody...
>
>  Do you use it yourself?  Is it useful?  Does it work?

Actually I'm not using it, because I'm OK with the Quick Marker and I
don't need anything else. But someone else could find it useful.

>  If yes, then does it break something?  Is it prone to cause crashes?

So far it does not seem to break anything. It simply adds a
configuration information in the XML document and does not change
anything else. And I guess RG files remain forwards- and backwards-
compatible.

A possible limitation is that it somewhat overlaps the shortcut
definition made in the main window, and there is no cross-control
between the two functions, so you may define a shortcut for a marker
and not know that it's already defined as an accelerator to call the
MIDI Device configuration for instance. Not a real showstopper, but
not clean.

>  Does it have a negative impact on the way someone is already used to working?

I see your point. I think it's not invasive. If you don't use it, you
don't even know it exists.

I will submit the patch later for your review, when I'm done with what
I'm working on at the moment.


Thanks for your feedback.

-- 
Best regards,
Philippe.