Menu
▾
▴
[Rhq-commits] [rhq-project.org rhq] [2672] [RHQ-1342] - alerts on config changes are suppressed if the update is the first one for the given resource;
|
From: <jma...@rh...> - 2009-01-20 13:08:18
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } --></style> <title>[rhq-project.org rhq] [2672] [RHQ-1342] - alerts on config changes are suppressed if the update is the first one for the given resource; </title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>2672</dd> <dt>Author</dt> <dd>jmarques</dd> <dt>Date</dt> <dd>2009-01-20 07:08:16 -0600 (Tue, 20 Jan 2009)</dd> </dl> <h3>Log Message</h3> <pre>[RHQ-1342] - alerts on config changes are suppressed if the update is the first one for the given resource; </pre> <h3>Modified Paths</h3> <ul> <li><a href="#rhqtrunkmodulesenterpriseserverjarsrcmainjavaorgrhqenterpriseserverconfigurationConfigurationManagerBeanjava">rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/configuration/ConfigurationManagerBean.java</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="rhqtrunkmodulesenterpriseserverjarsrcmainjavaorgrhqenterpriseserverconfigurationConfigurationManagerBeanjava"></a> <div class="modfile"><h4>Modified: rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/configuration/ConfigurationManagerBean.java (2671 => 2672)</h4> <pre class="diff"> <span class="info">--- rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/configuration/ConfigurationManagerBean.java 2009-01-20 11:28:33 UTC (rev 2671) +++ rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/configuration/ConfigurationManagerBean.java 2009-01-20 13:08:16 UTC (rev 2672) </span><span class="lines">@@ -736,10 +736,8 @@ </span><span class="cx"> current = null; // The resource hasn't been successfully configured yet. } </span><span class="rem">- // If the configuration has not changed since the last persisted version do not save a new - // version. </span><span class="add">+ // Don't bother persisting new entries if there has been no change </span><span class="cx"> if (current == null || !newConfiguration.equals(current.getConfiguration())) { </span><span class="rem">- </span><span class="cx"> // let's make sure all IDs are zero - we want to persist a brand new copy Configuration zeroedConfiguration = newConfiguration.deepCopy(false); </span><span class="lines">@@ -750,7 +748,10 @@ </span><span class="cx"> newUpdateRequest.setStatus(newStatus); entityManager.persist(newUpdateRequest); </span><span class="rem">- notifyAlertConditionCacheManager("persistNewResourceConfigurationUpdateHistory", newUpdateRequest); </span><span class="add">+ if (current != null) { + // If this is the first configuration update since the resource was imported, don't alert + notifyAlertConditionCacheManager("persistNewResourceConfigurationUpdateHistory", newUpdateRequest); + } </span><span class="cx"> resource.addResourceConfigurationUpdates(newUpdateRequest); </span> </pre> </div> </div> </body> </html> |