Re: [re2c-devel] UTF-8 support

[Dan N. <dan...@gm...>]

Thanks, this is a nice feature! The approach you are taking looks sound.

So, there is a problem with licensing and copyrights. The re2c code is in
the public domain, and the utf8.{h,c} code you use is copyrighted with a
MIT style license. If we add that code to re2c, then there is a mix and
things get messy. Do you think you could re-write the utf8 code (it isn't
very much) and place it in the public domain?

Second, as a general rule, we try to have as much test coverage as is
reasonable. Could you add some tests?

Third, I am not picky about code formatting, but I do prefer it to be
consistent within a code base and when evaluating changes, formatting
changes are distracting. I'd appreciate it if you avoid making formatting
changes of unrelated code in patches.

Last of all, I recently moved the code to git. I don't mind looking at
patches, but git forks and pull requests are easier to deal with. If you
are familiar with git, do you mind using that instead of a patch? Although
if you don't know git, I don't mind if you send a patch.


On Fri, Dec 13, 2013 at 8:23 AM, Ulya Fokanova <skv...@gm...> wrote:

> Sorry, forgot the patch itself.
>
> Ulya
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> re2c-devel mailing list
> re2...@li...
> https://lists.sourceforge.net/lists/listinfo/re2c-devel
>
>