Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#19 missing breaks for switches cases

open
nobody
None
5
2014-07-02
2013-02-19
Anonymous
No

I think these missing breaks are not intentional:

No break at the end of case rapidxml.hpp line 1846
No break at the end of case rapidxml.hpp line 1852
No break at the end of case rapidxml.hpp line 2148

Discussion

  • Bernd
    Bernd
    2014-07-02

    1846:
    Please read the documentation in the header for RAPIDXML_PARSE_ERROR.
    RAPIDXML_PARSE_ERROR is defined to NEVER return.
    1852: Last case (a "Default"). Doesn't need a break.
    2148: Last case... same as above.

    I know.. would be nice to have a break here - at least for better readability.
    But this should be mentioned in a bug-report!