#185 'Adjust start time' strange behavior

[Sheldon]

Rachota 2.4 build #111229:
The 'Adjust start time' functionality does not work correctly if the start time is moved backwards.

Scenario:
1) I move the start time from 8.00 am to 7.00 am. The system adjusts the start time and adds a 'Day start time adjustment' activity and adds one hour to this activity.
2) I now move the start time back to 8.00 am. The system adjusts the start time as expected but does not modify the time value of the 'Day start time adjustment' activity.

Expected behavior would be to set the time value of the 'Day start time adjustment' activity back to zero.

I understand that providing a general solution is difficult here as Rachota does not seem to support negative time values. However, the current behavior is surprising to the user.

[Jiri Kovalsky]

Well, I understand that it's confusing but as you correctly figured it out there is no ideal solution to this problem. I can fix this isolated case i.e. to remove the hour from the "Day start time adjustment" task but what should it do when:
1. there is no such task and you for instance shift start time from 7:00 to 8:00?
2. there is such task with 1 hour and you shift start time from 7:00 to 9:00?
In my opinion the current implementation solves vast majority of cases when users forget to start Rachota in the morning.

[Jiri Kovalsky]

Improved adjustment task creation logic when updating start time. Now the task is removed when new duration should be negative or its duration is updated depending on the time change. The bug is fixed in Rachota 2.4 build #200222.

https://sourceforge.net/p/rachota/code/ci/28f18895cd466b671c74dc99406cce8ef6b19c4d/