Re: [Qlandkartegt-users] [GarminDev/Patch] fix issues found by cppcheck

[Oliver E. <oli...@gm...>]

Hi Albrecht,

thanks for the work. I committed the patch to the repository. However I 
am not able to test it because I have now device. Thus let's simply 
trust it's not breaking anything.


Oliver


> Hi all,
>
> after running cppcheck [1] against some of my own applications which
> found several issues (plus lots of false positives, unfortunately), I
> tried it on QLandkarte GT.  Attached is a bunch if fixes for GarminDev
> which are not critical (mostly, at least), but IMHO clean up the code.
> If you think this makes sense, I'll do the same for the "main" code...
>
> Opinions?
>
> Cheers,
> Albrecht.
>
> [1] <http://sourceforge.net/projects/cppcheck>
>
> ---
> * src/Garmin.cpp: remove several out-of-bounds assignments - totally
> harmless unless the compiler decides to re-order them
> * src/CSerial.cpp: remove redundant break and a unused variable
> * src/GPSMap76/CDevice.cpp, src/EtrexLegend/CDevice.cpp,
> src/EtrexLegendC/CDevice.cpp: catch realloc() returning NULL (*very*
> unlikely, but will lead to a crash if it happens)
> * src/GPSMap60CSx/CDevice.cpp, src/ForeRunner/CDevice.cpp: remove unused
> variables
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Qlandkartegt-users mailing list
> Qla...@li...
> https://lists.sourceforge.net/lists/listinfo/qlandkartegt-users
>