From: Joerg L. <jo...@us...> - 2007-12-04 10:17:09
|
Hi Laurie, many thanks for the patch. The code is tricky and not the nicest one; it is still waiting for a serious cleanup, so I really appreciate your effort! On 01.12.07, Laurence Tratt wrote: > Myself and Eric Faurot have recently ported PyX to OpenBSD. This was mostly > a simple affair, but there is one serious bug in PyX 0.10 which causes > frequent crashes when calling TeX. Eric has spent some time tracking this > down, and has resolved the problem on OpenBSD. In Eric's words this was due > to "an interrupted read, and a thread starting too early". Since there's > nothing obviously OpenBSD-looking about his patch, I am hopeful that it will > not impact on other platforms. Calling start in the thread constructor is indeed not correct. Concerning the interrupted read, that's also a good catch! I would only prefer to use the errno provided in the errno module: errno.EINTR. Btw, I recently had some problems with PyX under Windows in combination with the TeXLive distribution and now wonder whether your patch would have also helped... I never got around to look into it more seriously, though. If I remember correctly, the problem in the example file just appears in the released tarball, and should not be present in the SVN repository. > Please find both patches at the end of this mail. It would be great if they > could be included in the next version of PyX! Done. Joerg |