Re: [PyX-user] fix for histogram keys

[Andre W. <wo...@us...>]

Hi Imran,

On 03.07.07, Imran Rashid wrote:
> I have a small fix for keys in histograms.  I'd like my histogram keys
> to show the shading of the boxes, not just the lines -- changing line
> 1189 in the key_pt method for histrograms in style.py to
> 
> graph.store(path.rect(x_pt, y_pt, width_pt, height_pt), 
> privatedata.lineattrs)
> 
> fixes this. The diff is attached.

Yes, I consider this a bug. However I guess most people want to have a
single line only when not filling the histogram. Are you using the
fillable flag on the style (would just be interesting for me to know).
In certain cases it's needed for proper filling support by the path.
We could make the style change of the graph key a side effect of the
fillable flag, but I'm not totally sure whether such a side effect is
the best way. Otherwise we could spend another flag to the style. I'm
not sure what's best here. Feel free to make your comment.

Best,


André

-- 
by  _ _      _    Dr. André Wobst
   / \ \    / )   wo...@us..., http://www.wobsta.de/
  / _ \ \/\/ /    PyX - High quality PostScript and PDF figures
 (_/ \_)_/\_/     with Python & TeX: visit http://pyx.sourceforge.net/