[Pywinauto-users] Re: [pywinauto - Open Discussion] RE: suggestions for speedup
Status: Alpha
Brought to you by:
mcmahon_m
From: Mark Mc M. <mar...@gm...> - 2006-03-27 11:06:42
|
Tail End(?) of discussion from SourceForge forums - my reply below... On 3/26/06, SourceForge.net <no...@so...> wrote: > > Read and respond to this message at: > https://sourceforge.net/forum/message.php?msg_id=3D3651230 > By: stefaanhi > > I tried out my proposed changes on my PC at home. > (I even temporarily reinstalled windows for that purpose ! ) > > The result is that the code becomes shorter, > more readable and runs almost twice as fast > for a simple dialog (i.e. the putty ssh configuration dialog) - without e= ven > touching RecordMatch. > > Happy happy, joy joy. > I can send you my changes if you like, > they are fairly trivial, consisting mostly > of removing lines of code ;) > > The only drawbacks I see are > 1) the need to install the python Levenshtein package, a windows installe= r being > available at https://dev.livingreviews.org/sec-cgi-bin/epubtktrac/wiki/Wi= nInstal > l > 2) the Levenshtein ratio is not exactly the same number as the difflib ra= tio > (usually equal to difflib's or a little higher), which in theory could br= eak > some existing automation scripts. > > Both drawbacks could be overcome though: > maybe the matching algorithm can be made pluggable with difflib's as defa= ult? > > Best regards, > Stefaan. > Hi Stefaan, OK - did the re.compile and the distance fix (about 1 second difference in the unit test run (from 61.5 seconds to 60.5 seconds). So the majority of the fix must come from the Levenshtein replacement of difflib. The only part of that that I don't like very much is that it has a GPL licence - and I don't really want to go there. But I don't see a problem with having it pluggable. I will look into that. Are you able write to the list using gmane? (I don't know I have't used it) http://news.gmane.org/gmane.comp.python.pywinauto.user I did a quick test and modifing application.Application.RecordMatch to just return immediately shaves off another 2 seconds from the unit test run (from 60.5 to 58.7). Thanks for your suggestions!! Mark |