[pywin32-bugs] [ pywin32-Feature Requests-3244607 ] pywin32 for PyPy

[SourceForge.net <no...@so...>]

Feature Requests item #3244607, was opened at 2011-03-25 19:40
Message generated for change (Comment added) made by amauryf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551957&aid=3244607&group_id=78018

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Amaury Forgeot d'Arc (amauryf)
Assigned to: Nobody/Anonymous (nobody)
Summary: pywin32 for PyPy

Initial Comment:
I've just managed to make pywin32 compile and work on top of PyPy.
I open this ticket to keep track of the various changes that I made to the pywin32 source code.
I'm currently preparing patches; for the moment, changes are of two kinds:

- In some .cpp files you can find "if PyString_Check(xxx)" without surrounding parentheses. This works on CPython because PyString_Check is actually a macro which adds parentheses to its expression; with PyPy PyString_Check is a function.

- With PyPy it's not allowed to change ob_type after object creation. This is used a lot by all PyIBase subclasses. The solution I found is to pass the TypeObject to the base constructor, and ensure that ob_type is set just before calling _Py_NewReference(). Of course these two lines can be replaced by "PyObject_Init(this, type);"


----------------------------------------------------------------------

>Comment By: Amaury Forgeot d'Arc (amauryf)
Date: 2011-03-26 11:09

Message:
PyObject_Init is already present in Python2.2

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2011-03-26 01:46

Message:
Sounds great to me.  Use of PyObject_Init sounds good too so long as it
also works in earlier Python version (I seem to recall that function was
added in later versions).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=551957&aid=3244607&group_id=78018