Re: [PythonReports-users] Patch for editor save and save-as options
Brought to you by:
a1s
From: Werner F. B. <wer...@fr...> - 2012-12-08 08:21:04
|
Hi Alex, I am waiting for the fat to melt, so a little time in front of computer. On 08/12/2012 07:46, alexander smishlajev wrote: > On 08.12.2012 0:01, Werner F. Bruhin wrote: >>> Text diff is fine, just don't use HTML in emails. >> Noted, and I set you and the list address as "text" recipient - >> but not sure this takes - is this one coming in as html for you? > This one is plain text. > >> Do you consider the WIT and the Persist stuff too, or do you have an >> issue with them - no problem either way. > Yes, I do consider, and yes, I have issues. ... > > For SetState fix, I don't understand why this method should not be > called in user code. I don't know why such calls are needed, either. So > I'm waiting when I meet with Den to ask him how this should be handled. I don't think SetState needs to be called, I think the base control does already do the "right" thing - at least to my eyes (but I am known to overlook little graphical differences). > > For Widget Inspection Tool, I understand that it is useful for UI > hacking, but I don't see it needed in production application. It's like > debug prints: you insert print statements all around your code, find > your bug, and then remove those prints. Perhaps it could be added with > InitInspection call hidden under "if False", but I did not made my mind > about that yet. Usually unneeded imports are not good for application > size and, mainly, for start-up times. I kind of agree, but:) - I don't use print statements to debug:), mostly use WingIDE to debug and lately I started using the Python logging module - I find having the WIT always there is very very very handy, even in production code. Haven't looked at what the overhead is but I didn't see a big increase in my shareware which I package with py2exe - so if I need to debug a py2exe'd version I just press ctrl-alt-i and get pretty far with this. Obviously totally up to you how you want to handle in PythonReports, what about a command line option "-d" and if present then the WIT.App is used, otherwise the normal wx.App. > > For element size change, there is a note that MinSize has issues. I'd > like to hear a comment from Den, too. Anyway, 50 is too big: there are > certain uses for elements with height near zero. What about putting MinSize back to -1 and do a call to SetInitialSize with 50 or something like that? Haven't tested if that would work. > > I have checked in font family fix. > > For persistence, I have just looked through it more carefully, and I > thing that will do. I'd probably add that after looking through code > yet another time. Note that the one style I use on this is only in recent versions of wx.lib.agw.persist, so if you test on wx 2.8 you need to get the agw stuff from SVN or condition the style setting (PM.PM_RESTORE_CAPTION_FROM_CODE) with version 2.9>. You might also want to consider moving the one line from the close event handler to a menu handler, so one saves the layout when one is happy and not on each close of the application. > >> Have a nice weekend - doing "confit de canard" over the next couple of >> days - so less time for computers:). > Wow! Does it take several days of intensive cooking? Yes it takes about 2-3 days but not full time. Yesterday we were cutting the four ducks up (2 persons for about 4 hours) and put some of it in the freezer, now the fat is being melted down (which one needs to check very often) and then this after noon we are doing the "confit" bit, which is cooking the meat which hasn't gone into the freezer in the melted down fat and then we put it into chars and sterilize it. And then we do the same thing again in early January - just to make sure that we don't starve next year:-) . Have a nice weekend Werner |