From: Billy G. A. <bal...@us...> - 2001-09-23 04:02:19
|
Update of /cvsroot/pypgsql/pypgsql In directory usw-pr-cvs1:/tmp/cvs-serv17679 Modified Files: pgresult.c Log Message: 21SEP2001 bga I have removed resultErrorMessage as an attribute. It doesn't make sense to leave it since it will always be None. Why? Because any query that generates an error will raise an exception, not return a PgResult. Index: pgresult.c =================================================================== RCS file: /cvsroot/pypgsql/pypgsql/pgresult.c,v retrieving revision 1.9 retrieving revision 1.10 diff -C2 -d -r1.9 -r1.10 *** pgresult.c 2001/09/16 17:54:52 1.9 --- pgresult.c 2001/09/23 04:02:17 1.10 *************** *** 29,32 **** --- 29,36 ---- | Date Ini Description | | --------- --- ------------------------------------------------------- | + | 21SEP2001 bga I have removed resultErrorMessage as an attribute. It | + | doesn't make sense to leave it since it will always be | + | None. Why? Because any query that generates an error | + | will raise an exception, not return a PgResult. | | 14SEP2001 bga Removed code related to PostgreSQL 6.5.x. We now only | | support PostgreSQL 7.0 and later. | *************** *** 116,126 **** self->type = Py_BuildValue("i", type); self->status = Py_BuildValue("i", PQresultStatus(res)); - if (*(m = PQresultErrorMessage(res)) == (char)0) - { - Py_INCREF(Py_None); - self->errmsg = Py_None; - } - else - self->errmsg = Py_BuildValue("s", m); self->ntuples = Py_BuildValue("i", PQntuples(res)); self->nfields = Py_BuildValue("i", PQnfields(res)); --- 120,123 ---- *************** *** 733,737 **** { "resultType", T_OBJECT, RsOFF(type), RO }, { "resultStatus", T_OBJECT, RsOFF(status), RO }, - { "resultErrorMessage", T_OBJECT, RsOFF(errmsg), RO }, { "ntuples", T_OBJECT, RsOFF(ntuples), RO }, { "nfields", T_OBJECT, RsOFF(nfields), RO }, --- 730,733 ---- |