[Pyobjc-dev] Re: [Pyobjc-checkins] [PyObjC-svn] r1680 - trunk/pyobjc/Modules/objc

[Bob I. <bo...@re...>]

On May 24, 2005, at 1:57 PM, ron...@re... wrote:

> Author: ronaldoussoren
> Date: Tue May 24 15:57:53 2005
> New Revision: 1680
>
> Modified:
>    trunk/pyobjc/Modules/objc/libffi_support.m
>    trunk/pyobjc/Modules/objc/objc-object.h
>    trunk/pyobjc/Modules/objc/objc-object.m
>    trunk/pyobjc/Modules/objc/selector.m
> Log:
> A (partial?) fix for bug 1206669.
>
> This changes the generic IMP to not -retain self unless the Python  
> proxy will
> stay alive when the IMP returns. This patch passes all unittests  
> (including
> the one I added earlier today), but I haven't tested using real  
> applications
> yet.

Excellent, this is almost what I had written (but went about it a  
harder way, and ran into some trouble).  Thanks!

There are a bunch of cleanups we should make though, like correcting  
the spelling of PyObjCObject_NewUninitialized and unifying some of  
that code (there's like four page-long functions in there that do  
almost the same thing).

-bob