Re: [Pydev-code] Who instantiates FastPythonPartitionScanner?

[Fabio Z. <fa...@es...>]

On Fri, Apr 30, 2010 at 11:56 AM,  <cla...@at...> wrote:
> Thanks for the reply, and sorry for the top-posting; my web-based client
> does not work well any other way.
>
> The FastPythonPartitionScanner class looks like interesting code. What would
> it take to finish it? Just from looking at the code, I notice:
> 1) No constructor for the class.
> 2) The PyCodeScanner class (is this unused? i.e. only used with
> FastPythonPartitionScanner) seems to have a cut and paste error:
>    public void updateColors() {
>         setupRules();
>     }
>
> The setupRules() call seems to be from a cut and pasted method.
> 3) How much would plugin.xml for org.python.pydev have to change to use the
> new scanner? Is the extension point the same as for the current scanner?
> Just curious how close the combination of FastPythonPartitionScanner,
> PyCodeScanner, and PyColoredScanner are to being completed and useful.

Actually, the PyCodeScanner and PyColoredScanner already work well
with the PyPartitionScanner. The FastPythonPartitionScanner was meant
to be a drop-in replacement of the PyPartitionScanner to fix one
issues when string partitions are changed (and I'm not sure what would
it take to finish it without actually going through the process of
implementing it). The code in the PyCodeScanner seems correct for me.

Cheers,

Fabio