Pure Data Computer Music System / Patches / #482 Win32: use binary open mode by default everywhere

#482 Win32: use binary open mode by default everywhere

Milestone: bugfix

Status: open

Owner: Hans-Christoph Steiner

Labels: pd-extended (22)

Priority: 5

Updated: 2012-12-21

Created: 2012-12-18

Creator: Hans-Christoph Steiner

Private: No

This patch enables binary open mode on Win32 everywhere, thereby ignoring the special Win32 "text" translation mode. This makes the Win32 API more like the POSIX API, which is used by every other platform Pd supports.

But it seems to break somethings, like the loading of some soundfiles. Attached is an example patch for the failure.

Discussion

Hans-Christoph Steiner - 2012-12-18

patch to apply with 'git am'

0006-Win32-use-binary-file-mode-by-default-we-don-t-want-.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Miller Puckette - 2012-12-18

Just tried this in Wine and then (swear words deleted here) cranked up my XP SP2 machine and tried it
there too - I can't see anything wrong yet. Is it breaking on a more recent version of Windows?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Hans-Christoph Steiner - 2012-12-18

strange, I guess its conflicting with something in MinGW... that's the only way I ever compile on Windows.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Hans-Christoph Steiner - 2012-12-21

labels: 680704 --> pd-extended

assigned_to: nobody --> eighthave
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Hans-Christoph Steiner - 2012-12-21

assigning this to Pd-extended, since its already included in vanilla

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous