From: Peng <how...@gm...> - 2013-09-03 08:27:13
|
Hi Marcelo, the patches were based on branch 1.6.x, not the master. Maybe it caused the problem. Next time I will commit changes to a git clone of the master branch, and make pull request, which will ease the process of review and merge. I will also take care of the ChangeLog file. Peng On 09/03/2013 01:41 AM, Marcelo Roberto Jimenez wrote: > Hi Peng, > > I have committed your patch. > > Would you mind using "git format-patch" to produce your patches in the > future? I am having problems to commit your patches, that simple > measure would simplify my work a lot. > > Also, in the same patch, please explain your changes in the ChangeLog > file. > > Regards, > Marcelo. > > > > On Sat, Aug 24, 2013 at 7:52 AM, Peng <how...@gm... > <mailto:how...@gm...>> wrote: > > Correct indentation settings and re-submit the patch. > > Peng > > > On 08/24/2013 06:45 PM, Peng wrote: > > Hi, > please review the attached patch, which includes the following > changes: > > 1) restore the scanner's original cursor position in case of > insufficient input; > 2) free the memories allocated for a new header in case of a > failure. > > Peng > > > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance > Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > pupnp-devel mailing list > pup...@li... > <mailto:pup...@li...> > https://lists.sourceforge.net/lists/listinfo/pupnp-devel > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > > > _______________________________________________ > pupnp-devel mailing list > pup...@li... > https://lists.sourceforge.net/lists/listinfo/pupnp-devel |