[pupnp-devel] Fwd: Mac OSX Patchset

[Marcelo J. <mar...@gm...>]

Hi Ingo,

First, before I forget again, please post the exact lines you are
using to bootstrap. I am not able to reproduce the erratic behavior
here. I do like this:

svn up && ./bootstrap && ./configure --enable-debug
--prefix=/home/myself/usr/libupnp && make > /dev/null && make install
> /dev/null

On Jan 22, 2008 8:20 AM, Ingo Hofmann <ing...@ii...> wrote:
>
> I still have a major problem with autoconf/automake in the svn-sources.
> I can't bootstrap on neither Kubuntu 7.10, Debian Etch, MacOS X 10.4 nor
> 10.5. The resulting configure script always produces syntax errors. When
> looking at the script, those are missing newlines. The only clue I got
> on that so far is, when not running autoreconfigure but the single steps
>   sperately:

Would you mind posting here the versions of autoconf and automake that
you are using? I have

$ autoconf --version
autoconf (GNU Autoconf) 2.60

$ automake --version
automake (GNU automake) 1.9.6

> mbp041:libupnp-trunk hfi$ automake --add-missing --copy
> configure.ac:131: required directory ./config.aux does not exist

That means that the directory config.aux has not been created. It
should have been created because autoconf has been told to do so here
(configure.ac, line 131):

AC_CONFIG_AUX_DIR(config.aux)

> cp: config.aux/compile: No such file or directory
> configure.ac:254: installing `config.aux/compile'
> configure.ac:254:     error while copying
> cp: config.aux/config.sub: No such file or directory
> configure.ac:142: installing `config.aux/config.sub'
> configure.ac:142:     error while copying
> cp: config.aux/missing: No such file or directory
> configure.ac:136: installing `config.aux/missing'
> configure.ac:136:     error while copying
> cp: config.aux/install-sh: No such file or directory
> configure.ac:136: installing `config.aux/install-sh'
> configure.ac:136:     error while copying
> cp: config.aux/config.guess: No such file or directory
> configure.ac:142: installing `config.aux/config.guess'
> configure.ac:142:     error while copying

Those are all explained by the inexistence of the directory config.aux.

> ixml/Makefile.am:15: ENABLE_DEBUG does not appear in AM_CONDITIONAL

This is very strange.

> cp: config.aux/depcomp: No such file or directory
> ixml/Makefile.am: installing `config.aux/depcomp'
> ixml/Makefile.am:     error while copying

Idem for no config.aux.

> threadutil/Makefile.am:10: ENABLE_DEBUG does not appear in AM_CONDITIONAL
> upnp/Makefile.am:26: ENABLE_TOOLS does not appear in AM_CONDITIONAL
> upnp/Makefile.am:114: ENABLE_TOOLS does not appear in AM_CONDITIONAL
> upnp/Makefile.am:117: ENABLE_DEBUG does not appear in AM_CONDITIONAL
> upnp/sample/Makefile.am:20: ENABLE_SAMPLES does not appear in AM_CONDITIONAL
> upnp/sample/Makefile.am:21: ENABLE_CLIENT does not appear in AM_CONDITIONAL
> upnp/sample/Makefile.am:27: ENABLE_DEVICE does not appear in AM_CONDITIONAL
> upnp/sample/Makefile.am:34: ENABLE_DEVICE does not appear in AM_CONDITIONAL

Idem for very strange.

> configure.ac:255: required file `config.aux/ltmain.sh' not found

Idem for no config.aux

> What's interesting about that is, that the part containing
> AM_CONDITIONAL matches the parts in the configure scripts, where the
> newlines are missing. Unfortunately I'm not that deep into autotools to
> come up with a fix :(

I don't know, I am kinda lost here, but I don't think it has to do
with newlines. In any case, I have added svn:eol-style=native to some
files that were missing it, but none of the files seem related to it.

You said you can compile from the tarball. You can try to do this from
a fresh svn checkout: Copy the attached configure file in this email
and do:

$ ./configure && make dist

This will (I hope) create libupnp-1.6.4.tar.bz2. Unpack this in a new
directory, as if you had downloaded it from sourceforece, and post the
results here.

> Ok, it all boils down to this: I can't test against trunk, but I did
> test against the 1.6.3 tarball and it worked. I attched my patch-file,
> which fixes 3 issues:
> - 1.6.3-tarball now compiles on OSX at all
> - Replaced all occurences of __OSX__ with __APPLE__
> - Fixes setsockopt() in Threadpool.c to allow more than one process to
>    join the multicast-group on OSX
> Next time, I will split that up in different patches.

Thanks! I have not replaced all the occurrences of __OSX__, I have
added __APPLE__ instead. I am still not sure that __OSX__ is never
defined in the universe, so I will keep it and wait for some feedback
before removing it.

I have committed your fix to setcockopt in Threadpool.c, thank you for that!

> I hope those patches help you. If you have any clues on how to boostrap
> the svn-sources, I would be very pleased and could test my stuff the
> next time before commiting ;)
>
> Thanks in advance and keep up the good work!

I think it can be a problem with the version of autoconf/automake we
are using. Maybe you are using a newer version that has some
constraints that I am not aware of and maybe they have changed the
behavior of the macro AC_CONFIG_AUX_DIR.

Please, keep the feedback so that we can fix this issue.

> Ingo

Regards,
Marcelo.