[proteowizard-developer] Fwd: RAMPAdapter

[Brian P. <bri...@in...>]

Anyone object to this change?  The problem this was originally
addressing, "prevent pwiz from reading metadata twice", is now handled
automatically for mzML and mzXML.   As it stands, it's a performance
hit for the unwary as code that is meant to just skim the metadata
suddenly reads everything when you cut over from RAMP to RAMPadapter.

Index: C:/ProteoWizard/pwiz/pwiz/data/msdata/RAMPAdapter.hpp
===================================================================
--- C:/ProteoWizard/pwiz/pwiz/data/msdata/RAMPAdapter.hpp       (revision 3002)
+++ C:/ProteoWizard/pwiz/pwiz/data/msdata/RAMPAdapter.hpp       (working copy)
@@ -55,7 +55,12 @@
    int getScanNumber(size_t index) const;

    /// fills in RAMP ScanHeaderStruct for a specified scan
-    void getScanHeader(size_t index, ScanHeaderStruct& result, bool
reservePeaks = true) const;
+    ///
+    /// you can optionally preload the peaklists too, but the
+    /// RAMP interface this emulates doesn't normally do that,
+    /// so defaulting reservePeaks to true would be a nasty surprise
+    /// performance-wise to anyone switching over from actual RAMP
+    void getScanHeader(size_t index, ScanHeaderStruct& result, bool
reservePeaks = false) const;

    /// fills in m/z-intensity pair array for a specified scan
    void getScanPeaks(size_t index, std::vector<double>& result) const;