From: Matthew C. <mat...@va...> - 2009-12-21 22:01:53
|
How 'bout UserParam/ParamContainer/ParamGroup? It could be confusing to not move these if CVParam moves (especially since they're also all used by MSData/MzIdentML/TraData). But UserParam doesn't make sense in pwiz::cv. :P -Matt Darren Kessner wrote: > I think it's a good idea. I like pwiz::cv. > > > Darren > > > > On Mon, Dec 21, 2009 at 12:25 PM, Matthew Chambers > <mat...@va...> wrote: > >> Hi all, >> >> I'd like to move CV/CVParam/UserParam into pwiz/data/common for pwiz 2.0 >> since they are now used by msdata, tradata, mziddata, and sooner or >> later proteome as well. I'm a bit stuck about what namespace to use >> though. We moved CVID to the pwiz namespace a few months ago and I'd now >> like to move it to a child namespace like pwiz::data or pwiz::cv. But I >> don't want to unilaterally pick between the first option or whether to >> use both of them (Index/MemoryIndex/BinaryIndexStream went in pwiz::data >> and wouldn't make sense in pwiz::cv). This is not just a cosmetic >> change, it means that using the non-msdata modules with CV support won't >> drag in the full msdata module. I will of course handle all the >> necessary downstream changes to make sure everything still builds. >> >> Thoughts? >> -Matt > |