[ProFTPD-committers] CVS: proftpd/src encode.c,1.26,1.27

[TJ S. <cas...@us...>]

Update of /cvsroot/proftp/proftpd/src
In directory sfp-cvsdas-2.v30.ch3.sourceforge.com:/tmp/cvs-serv3507/src

Modified Files:
	encode.c 
Log Message:

More notes to myself regarding possible encoding failures and their causes.


Index: encode.c
===================================================================
RCS file: /cvsroot/proftp/proftpd/src/encode.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- encode.c	14 Apr 2010 21:04:13 -0000	1.26
+++ encode.c	18 Apr 2010 18:42:16 -0000	1.27
@@ -72,6 +72,15 @@
 #endif
 
     if (nconv == (size_t) -1) {
+
+      /* Note: an errno of EILSEQ here can indicate badly encoded strings OR
+       * (more likely) that the source character set used in the iconv_open(3)
+       * call for this iconv_t descriptor does not accurately describe the
+       * character encoding of the given string.  E.g. a filename may use
+       * the ISO8859-1 character set, but iconv_open(3) was called using
+       * US-ASCII.
+       */
+
       return -1;
     }