[ProFTPD-committers] CVS: proftpd/contrib mod_tls.c,1.34,1.35

[TJ S. <cas...@us...>]

Update of /cvsroot/proftp/proftpd/contrib
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9674/contrib

Modified Files:
	mod_tls.c 
Log Message:

When walking the server_list list, we need to start with server_list->xas_list,
not just server_list.  This is a subtle and easy to miss bug, and was causing
the list-walking code to attempt to access inaccessible memories (not good).

This highlights a need for a good list/set-iterating API, rather than relying
on details of the actual structures.


Index: mod_tls.c
===================================================================
RCS file: /cvsroot/proftp/proftpd/contrib/mod_tls.c,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- mod_tls.c	30 Jan 2004 03:37:42 -0000	1.34
+++ mod_tls.c	10 Feb 2004 04:07:03 -0000	1.35
@@ -3218,7 +3218,7 @@
   server_rec *s = NULL;
   char buf[256];
 
-  for (s = (server_rec *) server_list; s; s = s->next) {
+  for (s = (server_rec *) server_list->xas_list; s; s = s->next) {
     config_rec *rsa = NULL, *dsa = NULL;
     tls_pkey_t *k = NULL;