[Prboom-notes] [ prboom-Patches-1223337 ] compat option: any last boss death triggers 666

[SourceForge.net <no...@so...>]

Patches item #1223337, was opened at 2005-06-18 21:45
Message generated for change (Comment added) made by jond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=303396&aid=1223337&group_id=3396

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jonathan Dowland (jond)
Assigned to: Nobody/Anonymous (nobody)
>Summary: compat option: any last boss death triggers 666

Initial Comment:
The classic UAC_DEAD.WAD relied on some behaviour in
the original doom which wasn't preserved in the current
source code.

1) when the last baron dies, all sectors tagged 666
have their floor dropped to the next lowest. This works now
2) when the cyber is killed, all sector 666 are dropped
to the next lowest, this doesn't work. 

The second step worked originally because

1) the sector that the cyb was supposed to drop
couldn't drop when the baron's died, as all adjacent
floors were higher
2) the 

It only worked originally because the sector concerned
didn't have a lower floor adjacent to it, but once the
other 666 floors dropped, it did. Also A_BossDeath
didn't check to see which monster death called the code
pointer.

The current source code does check to ensure that only
baron deaths on E1M8 trigger 666. This patch adds a
compatibility option to skip this check. Therefore any
 death which calls the code pointer invoking
A_BossDeath (i.e. barons, cybers, spiders...) will
invoke 666. UAC_DEAD now works :-)

Developed against 2.2.6 in debian, but works and
applies cleanly to svn checkout as of 2005-06-18.

----------------------------------------------------------------------

>Comment By: Jonathan Dowland (jond)
Date: 2005-08-21 20:39

Message:
Logged In: YES 
user_id=96503

Hi, I've just been looking over the 2.3 branch and I see
that cph put in some stub work for a 666 tag compatibility
option in 2001!n The notes say that the option would relax
the _level_ restriction for tag 666, "in line with 1.2
behaviour".

I've been performing experiments with versions 1.2, 1.666
and 1.9 via DOSBox. It appears that there was no MT_BRUISER
check on E1M8 (and most likely no monster type checks on any
of the levels) for any of versions 1.2, 1.666, 1.9: my tests
triggered it with cybers and barons in all three.

I also tested specific levels: with 1.2, the trigger
_didn't_ happen on E1M1, but it did on E1M8. So I'm not sure
where cph's comment comes from.

This patch applies against SVN checkout as of 20050820 and
extends the stub work to implement the behaviour I did for
2.2.3 in the previous patch. UAC_DEAD works with this option
set.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=303396&aid=1223337&group_id=3396