Re: [pptp-devel] sleep(3) vs waitpid

[Erland L. <er...@vo...>]

Rein Klazes wrote:

>Here is one small change. I will commit it later if there are no
>objections.
>
>This adds a small delay before pptp (the gre-process) exits. This to
>allow the control process to terminate. This prevents some ugliness if
>pptp is started immediately again. This can happen with pppd's
>"persist" option (if pptp is started that way) or for example when
>repawned by inittab.
>
>
>--------------------------------------------------------------------------
>--- ./pptp-linux/pptp.c	Sat Jul 21 12:02:08 2001
>+++ ./my-pptp/pptp.c	Fri Aug  3 19:39:13 2001
>@@ -203,6 +203,7 @@
>       kill(parent_pid, SIGTERM);
>   close(pty_fd);
>   close(callmgr_sock);
>+  sleep(3);     /* give ctrl manager a chance to exit */
>   exit(0);
> }
> 
>--------------------------------------------------------------------------
>
Sorry for butting in (I really don't know the details of the program), 
but I would think that if it were possible to do something like:

  waitpid( ctrl_manager_pid, ... );

That would be better than

  sleep( 3 )

Because it is guaranteed to wait for exactly as long as is needed, 
neither more nor less.

  /Erland