Re: [Postfixadmin-devel] postfixadmin with ldap

[Vikas P. <par...@gm...>]

Hi Christian,

Did you get the chance to look in it, as of now, i get stuck somewhere due
to fear(or you might say conflict that would come). My fear is that more
code more problem. So, i don't want to complete my code in one run.

Guide me if i am driving on wrong way.

Rg:
Vikas Parashar

On Fri, Feb 6, 2015 at 12:57 PM, Vikas Parashar <par...@gm...>
wrote:

> Hi Christian,
>
> Thanks you very much for your kind support.
>
> On Tue, Feb 3, 2015 at 5:43 PM, Christian Boltz <pos...@cb...>
> wrote:
>
>> Hello,
>>
>> Am Montag, 2. Februar 2015 schrieb Vikas Parashar:
>> > Can someone guide me?
>>
>> Yes, of course. Sorry for the delay!
>>
> There is nothing to say sorry, thank you for your valuable points.
>
>>
>> > On Tue, Jan 27, 2015 at 8:29 PM, Vikas Parashar wrote:
>> > > I have written some thing as per our discussion, Could you please
>> > > guide me how & where i can show you that functionality and my code?
>>
>> I think you are talking about uploading your changed files or patches.
>> The tracker on Sourceforge is probably the best place for this:
>>     http://sourceforge.net/p/postfixadmin/patches/
>> (Feel free to use a tarball if you want to upload multiple files.)
>>
>
> Ahh!, here i am using git, i can continue with svn as well. Personally, i
> think svn is too old fashion and very heavy. May be, we can think to move
> on git. Anyway, i can commit it to svn as well..
>
> I would like to request to you kindly see my code on my git repo when will
> you get the chance. Right from the beginning, i am looking for some
> guidelines. I know only one rule KISS(Keep it simply stupid). :)
>
> Please check it here https://vic...@gi.../vickally/postfixadmin.git
>
>
>
>
>> > > As i am not a core programmer, could you please guide me(or give me
>> > > some pointer) to write good code. So that, i can execute my idea in
>> > > better way.
>>
>> That's an interesting question ;-)
>> Short answer: for coding style, have a look at
>>     http://sourceforge.net/p/postfixadmin/wiki/Coding_guidelines/
>> which lists some basic rules.
>>
>> Besides that, we don't have written rules. Maybe the best question to
>> answer is : if someone forces you to change your code in a year, would
>> you happily do that or would you heavily protest? ;-)
>>
>
> That depends on requirement, situation and community feedback. Yes, i
> would happily do that if required.
>
>
>> If you are looking for some examples,
>> - model/*, edit.php and list.php are what I'd call "good" code
>> - most of the files in the main directory are, well, not so good. With
>>   the exception of edit.php and list.php, those files contain "grown"
>>   code which also collected quite some issues over the years that make
>>   maintenance harder.
>> - also, older versions of PostfixAdmin contain some interesting[tm]
>>   stuff I don't want to see again - especially lots of code duplication
>>   with different bugs in each copy :-/
>>
>>
>> Regards,
>>
>> Christian Boltz
>> --
>> Oh großer Meister! Darf man euch untertänigst darauf aufmerksam
>> machen, daß das diff'en von Postscriptfonts komplette Unterordner
>> synchronisiert und diff't, unter Berücksichtigung von Links? :-)
>> [Ratti in fontlinge-devel]
>>
>>
>