[ postfixadmin-Patches-3383236 ] preliminary code to merge vacation
Brought to you by:
christian_boltz,
gingerdog
From: SourceForge.net <no...@so...> - 2011-08-01 08:44:31
|
Patches item #3383236, was opened at 2011-07-31 14:38 Message generated for change (Comment added) made by jan-kruis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Vacation Group: SVN (please specify revision!) Status: Open Resolution: None Priority: 5 Private: No Submitted By: J.Kruis (jan-kruis) Assigned to: Nobody/Anonymous (nobody) Summary: preliminary code to merge vacation Initial Comment: this patch i use to get code in to sync toget later one template and one code voor edit-vacation and user-vacation regarde Jan Kruis ---------------------------------------------------------------------- >Comment By: J.Kruis (jan-kruis) Date: 2011-08-01 10:44 Message: Hi Christian, dont commit the patch it nown i upload a second patch with handel the return and removed some unused code in templates please have a look and i see up to remarks i have a look at the $smarty->assign remark reards jan ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2011-08-01 02:23 Message: I just had a quick look at your patch - looks good :-) - but as usual, I found "a hair in the soup" (as we germans say) ;-) In edit-vacation.php, you use (for $tSubject and $tBody) $smarty->assign ('tSubject', htmlentities ($tSubject, ENT_QUOTES, 'UTF-8'), false); You can most probably use this instead: $smarty->assign ('tSubject', $tSubject); (without the "false" as third parameter, $smarty->assign does the htmlentities() call itsself - see assign() and sanitize() in smarty.inc.php) Or did I overlook something? What's your preferred way to continue? Shall I commit your preliminary patch to SVN now or should I wait until you provide a non-preliminary patch? (I'd prefer to commit now, but it's your choice.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937966&aid=3383236&group_id=191583 |