[ postfixadmin-Bugs-2976010 ] edit-alias.php backwards in_array arguments

[SourceForge.net <no...@so...>]

Bugs item #2976010, was opened at 2010-03-24 17:41
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2976010&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: v 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: W. Rossmann ()
Assigned to: Nobody/Anonymous (nobody)
Summary: edit-alias.php backwards in_array arguments

Initial Comment:
144             if(in_array($orig_alias_list, $fAddress)) {

should be

144             if(in_array($fAddress, $orig_alias_list)) {

and seems to still be this way in the current SVN version. [r816, ln140]

Also, there seems to be a flaw in the logic of this file where if special_alias_control = NO the mailbox alias is removed, but is only restored if alias_control_admin = NO as well which essentially ~does~ let the domain admin control the default mailbox alias by virtue of it being removed if they do not add it back manually.

Lines relevant to the above are 73 and 142 in v2.3, 68 and 138 in SVN r816

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2010-05-17 00:02

Message:
The in_array issue was fixed in SVN r818.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2976010&group_id=191583