[poe-commits] SF.net SVN: poe: [2173] trunk/poe

[<rc...@us...>]

Revision: 2173
          http://svn.sourceforge.net/poe/?rev=2173&view=rev
Author:   rcaputo
Date:     2007-02-17 23:47:52 -0800 (Sat, 17 Feb 2007)

Log Message:
-----------
Stop setting $^W globally.  Fix a couple warnings as a result.  Thanks
to Ton Hospel for pointing out we were doing this.

Modified Paths:
--------------
    trunk/poe/lib/POE/Kernel.pm
    trunk/poe/lib/POE/Loop/IO_Poll.pm
    trunk/poe/t/10_units/03_base/02_api_ctl.t

Modified: trunk/poe/lib/POE/Kernel.pm
===================================================================
--- trunk/poe/lib/POE/Kernel.pm	2007-02-03 07:16:01 UTC (rev 2172)
+++ trunk/poe/lib/POE/Kernel.pm	2007-02-18 07:47:52 UTC (rev 2173)
@@ -306,9 +306,8 @@
     $value =~ tr['"][]d;
     $value = qq($value) if $value =~ /\D/;
 
-    BEGIN { $^W = 0; }
-
     no strict 'refs';
+    local $^W = 0;
     *$const = sub () { $value };
   }
 

Modified: trunk/poe/lib/POE/Loop/IO_Poll.pm
===================================================================
--- trunk/poe/lib/POE/Loop/IO_Poll.pm	2007-02-03 07:16:01 UTC (rev 2172)
+++ trunk/poe/lib/POE/Loop/IO_Poll.pm	2007-02-18 07:47:52 UTC (rev 2173)
@@ -350,7 +350,7 @@
         sleep($timeout);
       }
       else {
-        select(undef, undef, undef, $timeout);
+        CORE::select(undef, undef, undef, $timeout);
       }
     }
   }

Modified: trunk/poe/t/10_units/03_base/02_api_ctl.t
===================================================================
--- trunk/poe/t/10_units/03_base/02_api_ctl.t	2007-02-03 07:16:01 UTC (rev 2172)
+++ trunk/poe/t/10_units/03_base/02_api_ctl.t	2007-02-18 07:47:52 UTC (rev 2173)
@@ -10,6 +10,9 @@
 # should have exported 'poectl'
 ok( *poectl{CODE} == *POE::API::Ctl::poectl{CODE}, "poectl exported" );
 
+# no-op to reuse these things and avoid a warning
+1 if *poectl{CODE} == *POE::API::Ctl::poectl{CODE};
+
 # poectl takes 0, 1 or 2 parameters
 my $rv = do { local $SIG{__WARN__} = sub { };
   poectl('one', 'two', 'three', 'four') };


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.