[poe-commits] poe/tests/30_loops/00_base all_errors.pm,1.2,1.3 k_signals.pm,1.3,1.4 ses_session.pm,1.7,1.8

[<rc...@us...>]

Update of /cvsroot/poe/poe/tests/30_loops/00_base
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16924/tests/30_loops/00_base

Modified Files:
	all_errors.pm k_signals.pm ses_session.pm 
Log Message:
Remove POE::Session->new() from tests.  This wasn't an RT ticket, but
it should have been.


Index: all_errors.pm
===================================================================
RCS file: /cvsroot/poe/poe/tests/30_loops/00_base/all_errors.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** all_errors.pm	22 Nov 2004 18:04:14 -0000	1.2
--- all_errors.pm	28 Jan 2005 22:55:32 -0000	1.3
***************
*** 349,353 ****
  #print "ok 40\n";
  #
! #eval 'POE::Session->new( 1 )';
  #print 'not ' unless defined $@ and length $@;
  #print "ok 41\n";
--- 349,353 ----
  #print "ok 40\n";
  #
! #eval 'POE::Session->new( 1 )';  ### DEPRECATED
  #print 'not ' unless defined $@ and length $@;
  #print "ok 41\n";

Index: k_signals.pm
===================================================================
RCS file: /cvsroot/poe/poe/tests/30_loops/00_base/k_signals.pm,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** k_signals.pm	22 Nov 2004 00:13:53 -0000	1.3
--- k_signals.pm	28 Jan 2005 22:55:32 -0000	1.4
***************
*** 166,189 ****
  
  sub spawn_server {
!   POE::Session->new(
!     _start => sub {
!       $_[KERNEL]->alias_set("server");
!     },
!     do_thing => sub {
!       $_[KERNEL]->post($_[SENDER], thing_done => $_[ARG0]);
      },
-     _child  => sub { 0 },
-     _stop   => sub { 0 },
    );
  }
  
! POE::Session->new(
!   _start => sub {
!     spawn_server();
!     $_[KERNEL]->post(server => do_thing => 1);
    },
-   thing_done => sub { 0 },
-   _child  => sub { 0 },
-   _stop   => sub { 0 },
  );
  
--- 166,193 ----
  
  sub spawn_server {
!   POE::Session->create(
!     inline_states => {
!       _start => sub {
!         $_[KERNEL]->alias_set("server");
!       },
!       do_thing => sub {
!         $_[KERNEL]->post($_[SENDER], thing_done => $_[ARG0]);
!       },
!       _child  => sub { 0 },
!       _stop   => sub { 0 },
      },
    );
  }
  
! POE::Session->create(
!   inline_states => {
!     _start => sub {
!       spawn_server();
!       $_[KERNEL]->post(server => do_thing => 1);
!     },
!     thing_done => sub { 0 },
!     _child  => sub { 0 },
!     _stop   => sub { 0 },
    },
  );
  

Index: ses_session.pm
===================================================================
RCS file: /cvsroot/poe/poe/tests/30_loops/00_base/ses_session.pm,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** ses_session.pm	24 Nov 2004 22:25:25 -0000	1.7
--- ses_session.pm	28 Jan 2005 22:55:33 -0000	1.8
***************
*** 15,19 ****
  }
  
! test_setup(43);
  
  use POE;
--- 15,19 ----
  }
  
! test_setup(39);
  
  use POE;
***************
*** 139,167 ****
  for (my $i=0; $i<$machine_count; $i++) {
  
!   # Odd instances, try POE::Session->create
!   if ($i & 1) {
!     POE::Session->create(
!       inline_states => {
!         _start     => \&task_start,
!         _stop      => \&task_stop,
!         count      => \&task_run,
!         next_count => \&task_next_count,
!         _default   => \&task_default,
!       },
!       args => [ $i ],
!       heap => { got_heap => $i },
!     );
!   }
! 
!   # Even instances, try POE::Session->new
!   else {
!     POE::Session->new (
        _start     => \&task_start,
        _stop      => \&task_stop,
        count      => \&task_run,
        next_count => \&task_next_count,
!       [ $i ],
!     );
!   }
  }
  
--- 139,153 ----
  for (my $i=0; $i<$machine_count; $i++) {
  
!   POE::Session->create(
!     inline_states => {
        _start     => \&task_start,
        _stop      => \&task_stop,
        count      => \&task_run,
        next_count => \&task_next_count,
!       _default   => \&task_default,
!     },
!     args => [ $i ],
!     heap => { got_heap => $i },
!   );
  }
  
***************
*** 348,367 ****
  );
  
- # Old style (new) object session without event to method name map.
- POE::Session->new(
-   [ 2 ],
-   UnmappedObject->new => [ '_start', 'count', '_stop' ],
- );
- 
- # Old style (new) object session with event to method name map.
- POE::Session->new(
-   [ 3 ],
-   MappedObject->new => {
-     _start => 'my_start',
-     count  => 'my_count',
-     _stop  => 'my_stop',
-   },
- );
- 
  # New style (create) package session without event to method name map.
  POE::Session->create(
--- 334,337 ----
***************
*** 369,373 ****
      UnmappedPackage => [ '_start', 'count', '_stop' ],
    ],
!   args => [ 4 ],
  );
  
--- 339,343 ----
      UnmappedPackage => [ '_start', 'count', '_stop' ],
    ],
!   args => [ 2 ],
  );
  
***************
*** 381,401 ****
      },
    ],
!   args => [ 5 ],
! );
! 
! # Old style (new) package session without event to method name map.
! POE::Session->new(
!   [ 6 ],
!   UnmappedPackage => [ '_start', 'count', '_stop' ],
! );
! 
! # Old style (new) package session with event to method name map.
! POE::Session->new(
!   [ 7 ],
!   MappedPackage => {
!     _start => 'my_start',
!     count  => 'my_count',
!     _stop  => 'my_stop',
!   },
  );
  
--- 351,355 ----
      },
    ],
!   args => [ 3 ],
  );
  
***************
*** 461,472 ****
  print "ok 20\n";
  
! print 'not ' unless $default_count == ($machine_count * $event_count) / 2;
  print "ok 21\n";
  
! print 'not ' unless $got_heap_count == $machine_count / 2;
  print "ok 22\n";
  
  # Object/package sessions.
! for (0..7) {
    print 'not ' unless $objpack[$_] == $event_count;
    print 'ok ', $_ + 23, "\n";
--- 415,426 ----
  print "ok 20\n";
  
! print 'not ' unless $default_count == ($machine_count * $event_count);
  print "ok 21\n";
  
! print 'not ' unless $got_heap_count == $machine_count;
  print "ok 22\n";
  
  # Object/package sessions.
! for (0..3) {
    print 'not ' unless $objpack[$_] == $event_count;
    print 'ok ', $_ + 23, "\n";
***************
*** 498,526 ****
  package main;
  
! POE::MySession->new(
!   _start => sub {
!     $_[HEAP]->{object} = MyObject->new;
!     POE::MySession->new(
!       _start => sub {
!         $_[HEAP]->{object} = MyObject->new;
!         POE::MySession->new(
            _start => sub {
              $_[HEAP]->{object} = MyObject->new;
!             POE::MySession->new(
!               _start => sub {
!                 $_[HEAP]->{object} = MyObject->new;
!                 $_[KERNEL]->delay(nonexistent => 3600);
!                 $_[KERNEL]->alias_set('test4');
!               },
!               _parent => sub {
!                 $parent_called++;
!               },
!               _child => sub { }, # To shush ASSERT
!               _stop => sub {
!                 $stop_called++;
                },
!             ),
              $_[KERNEL]->delay(nonexistent => 3600);
!             $_[KERNEL]->alias_set('test3');
            },
            _parent => sub {
--- 452,499 ----
  package main;
  
! POE::MySession->create(
!   inline_states => {
!     _start => sub {
!       $_[HEAP]->{object} = MyObject->new;
!       POE::MySession->create(
!         inline_states => {
            _start => sub {
              $_[HEAP]->{object} = MyObject->new;
!             POE::MySession->create(
!               inline_states => {
!                 _start => sub {
!                   $_[HEAP]->{object} = MyObject->new;
!                   POE::MySession->create(
!                     inline_states => {
!                       _start => sub {
!                         $_[HEAP]->{object} = MyObject->new;
!                         $_[KERNEL]->delay(nonexistent => 3600);
!                         $_[KERNEL]->alias_set('test4');
!                       },
!                       _parent => sub {
!                         $parent_called++;
!                       },
!                       _child => sub { }, # To shush ASSERT
!                       _stop => sub {
!                         $stop_called++;
!                       },
!                     },
!                   );
!                   $_[KERNEL]->delay(nonexistent => 3600);
!                   $_[KERNEL]->alias_set('test3');
!                 },
!                 _parent => sub {
!                   $parent_called++;
!                 },
!                 _child => sub {
!                   $child_called++ if $_[ARG0] eq 'lose';
!                 },
!                 _stop => sub {
!                   $stop_called++;
!                 },
                },
!             );
              $_[KERNEL]->delay(nonexistent => 3600);
!             $_[KERNEL]->alias_set('test2');
            },
            _parent => sub {
***************
*** 533,593 ****
              $stop_called++;
            },
!         ),
!         $_[KERNEL]->delay(nonexistent => 3600);
!         $_[KERNEL]->alias_set('test2');
!       },
!       _parent => sub {
!         $parent_called++;
!       },
!       _child => sub {
!         $child_called++ if $_[ARG0] eq 'lose';
!       },
!       _stop => sub {
!         $stop_called++;
!       },
!     ),
!     $_[KERNEL]->delay(nonexistent => 3600);
!     $_[KERNEL]->alias_set('test1');
!     $_[KERNEL]->yield("stop");
!   },
!   _parent => sub {
!     $parent_called++;
!   },
!   _child => sub {
!     $child_called++ if $_[ARG0] eq 'lose';
!   },
!   _stop => sub {
!     $stop_called++;
!   },
!   stop => sub {
!     POE::Kernel->stop();
! 
!     my $expected;
!     if ($] >= 5.004 and $] < 5.005) {
!       warn(
!         "# Note: Perl 5.004-ish appears to leak sessions.\n",
!         "#       Consider upgrading to Perl 5.005_04 or beyond.\n",
        );
!       $expected = 0;
!     }
!     else {
!       $expected = 3;
!     }
  
!     print 'not ' unless $sessions_destroyed == $expected;
!     print "ok 31 # dest $sessions_destroyed sessions (expected $expected)\n";
  
!     # 5.004 and 5.005 have some nasty gc issues. Near as I can tell,
!     # data inside the heap is surviving the session DESTROY. This
!     # isnt possible in a sane and normal world. So if this is giving
!     # you fits, please consider upgrading perl to at least 5.6.1.
!     my $expected;
!     if($] >= 5.006 or ($] >= 5.004 and $] < 5.005)) {
!       $expected = 3;
!     } else {
!       $expected = 2;
      }
-     print 'not ' unless $objects_destroyed == $expected;
-     print "ok 32 # dest $objects_destroyed objects (expected $expected)\n";
    }
  );
--- 506,555 ----
              $stop_called++;
            },
!         },
        );
!       $_[KERNEL]->delay(nonexistent => 3600);
!       $_[KERNEL]->alias_set('test1');
!       $_[KERNEL]->yield("stop");
!     },
!     _parent => sub {
!       $parent_called++;
!     },
!     _child => sub {
!       $child_called++ if $_[ARG0] eq 'lose';
!     },
!     _stop => sub {
!       $stop_called++;
!     },
!     stop => sub {
!       POE::Kernel->stop();
  
!       my $expected;
!       if ($] >= 5.004 and $] < 5.005) {
!         warn(
!           "# Note: Perl 5.004-ish appears to leak sessions.\n",
!           "#       Consider upgrading to Perl 5.005_04 or beyond.\n",
!         );
!         $expected = 0;
!       }
!       else {
!         $expected = 3;
!       }
  
!       print 'not ' unless $sessions_destroyed == $expected;
!       print "ok 27 # dest $sessions_destroyed sessions (expected $expected)\n";
! 
!       # 5.004 and 5.005 have some nasty gc issues. Near as I can tell,
!       # data inside the heap is surviving the session DESTROY. This
!       # isnt possible in a sane and normal world. So if this is giving
!       # you fits, please consider upgrading perl to at least 5.6.1.
!       my $expected;
!       if($] >= 5.006 or ($] >= 5.004 and $] < 5.005)) {
!         $expected = 3;
!       } else {
!         $expected = 2;
!       }
!       print 'not ' unless $objects_destroyed == $expected;
!       print "ok 28 # dest $objects_destroyed objects (expected $expected)\n";
      }
    }
  );
***************
*** 595,603 ****
  $poe_kernel->run;
  print 'not ' unless $stop_called == 0;
! print "ok 33\n";
  print 'not ' unless $child_called == 0;
! print "ok 34\n";
  print 'not ' unless $parent_called == 0;
! print "ok 35\n";
  
  my $expected;
--- 557,565 ----
  $poe_kernel->run;
  print 'not ' unless $stop_called == 0;
! print "ok 29\n";
  print 'not ' unless $child_called == 0;
! print "ok 30\n";
  print 'not ' unless $parent_called == 0;
! print "ok 31\n";
  
  my $expected;
***************
*** 614,618 ****
  
  print 'not ' unless $sessions_destroyed == $expected;
! print "ok 36 # dest $sessions_destroyed sessions (expected $expected)\n";
  
  # 5.004 and 5.005 have some nasty gc issues. Near as I can tell,
--- 576,580 ----
  
  print 'not ' unless $sessions_destroyed == $expected;
! print "ok 32 # dest $sessions_destroyed sessions (expected $expected)\n";
  
  # 5.004 and 5.005 have some nasty gc issues. Near as I can tell,
***************
*** 632,636 ****
  
  print "not " unless $objects_destroyed == $expected;
! print "ok 37 # dest $objects_destroyed objects (expected $expected)\n";
  
  # This simple session just makes sure we can start another Session and
--- 594,598 ----
  
  print "not " unless $objects_destroyed == $expected;
! print "ok 33 # dest $objects_destroyed objects (expected $expected)\n";
  
  # This simple session just makes sure we can start another Session and
***************
*** 656,660 ****
    !$Config{useithreads}
  ) {
!   foreach (38..43) {
      print(
        "not ok $_ # Skip: Restarting Tk dumps core in single-threaded perl $]\n"
--- 618,622 ----
    !$Config{useithreads}
  ) {
!   foreach (34..39) {
      print(
        "not ok $_ # Skip: Restarting Tk dumps core in single-threaded perl $]\n"
***************
*** 667,689 ****
      inline_states => {
        _start => sub {
!         print "ok 38\n";
          $_[KERNEL]->yield("woot");
          $_[KERNEL]->delay(narf => 1);
        },
        woot => sub {
!         print "ok 40\n";
        },
        narf => sub {
!         print "ok 41\n";
        },
        _stop => sub {
!         print "ok 42\n";
        },
      }
    );
  
!   print "ok 39\n";
    POE::Kernel->run();
!   print "ok 43\n";
  }
  
--- 629,651 ----
      inline_states => {
        _start => sub {
!         print "ok 34\n";
          $_[KERNEL]->yield("woot");
          $_[KERNEL]->delay(narf => 1);
        },
        woot => sub {
!         print "ok 36\n";
        },
        narf => sub {
!         print "ok 37\n";
        },
        _stop => sub {
!         print "ok 38\n";
        },
      }
    );
  
!   print "ok 35\n";
    POE::Kernel->run();
!   print "ok 39\n";
  }