From: David H. <David.Hill@Sun.COM> - 2007-12-01 20:04:30
|
Glenn Randers-Pehrson wrote: >> At 04:22 PM 11/30/2007 -0500, David Hill wrote: >> > > >>> it should be: >>> if (white_x > (png_fixed_point) 2147483000L || >>> white_y > (png_fixed_point) 2147483000L || >>> red_x > (png_fixed_point) 2147483000L || >>> red_y > (png_fixed_point) 2147483000L || >>> green_x > (png_fixed_point) 2147483000L || >>> green_y > (png_fixed_point) 2147483000L || >>> blue_x > (png_fixed_point) 2147483000L || >>> blue_y > (png_fixed_point) 2147483000L) >>> > > I replied: > > >> PNG_UINT_31_MAX is 2147483647, and the division should get optimized away by the compiler preprocessor. >> > > The division is a mistake, so I suppose it should really read: > if (white_x > (png_fixed_point) PNG_UINT_31_MAX || > I can live with that :-) thanks, Dave |